Not allowed to search with only `profiles` or only `travellingAssets`

[jorgenosberg]

The current spec marks the travellers array as required in search-offers, despite travellers and profiles being equally valid types of travellers for a search. It should thus be possible to execute a search with only travellers, only profiles, or only travellingAssets, a combination of these – but never neither. At least one array needs to be present, and, if present, it needs to be non-empty.

A way to solve this in the spec would be to mark the arrays as required with anyOf:

anyOf:
  - required: [ travellers ]
  - required: [ profiles ]
  - required: [ travellingAssets ]

To enforce non-empty arrays the other arrays should then get the same treatment as travellers:

travellers:
  type: array
  minItems: 1
  maxItems: 10
  items:
    $ref: "#/components/schemas/individualTraveller"
    
profiles:
  type: array
  minItems: 1
  maxItems: 10
  items:
    $ref: "#/components/schemas/userProfile"

travellingAssets:
  type: array
  minItems: 1
  maxItems: 10
  items:
    $ref: "#/components/schemas/travellingAsset"

[edwinvandenbelt]

I think you're right. The most simple solution is to remove 'travellers' from the required list. Strange combinations of 'type' (also required) and this 'anyOf' construct will be misinterpreted (by generators). The 'anyOf' is not really usable anyhow (is there a minimum of 1 or could it be empty, and what is the advantage of 'required' in that case).

[jorgenosberg]

Another option which might be more tooling-friendly is an aggregate traveller object that maps to one of the three traveler types? That way, we can have a single travellers array which is required and that has a minItems: 1? This works with the Kotlin and Java generators, at least. We can also test this against other generators if needed