Client supplicant crash with secure_storage in subfolder (vfat)

[jnippula]

In the do_mkdir function in tee_supplicant/src/tee_supp_fs.c:

if (stat(path, &st) != 0 && !S_ISDIR(st.st_mode))
    return -1;

Should that have || (OR), not && (AND) ?

If stat somehow fails to fill the st, then the st could contain uninitialized data and the ISDIR check with it is not reasonable.

[jforissier]

Hi @jnippula, good catch! Could you please create a pull request with the proposed fix? Thanks!

[jnippula]

Done: #409

[github-actions]

This issue has been marked as a stale issue because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this issue will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.