Call for volunteers to improve code quality (fix warnings)

[jenswi-linaro]

This is a call for volunteers.

optee_ftpm compiles with quite a few warnings. We can't be sure that all are harmless so they should preferably be fixed.

Please start small and fix only a few warnings at a time. This makes the review easier and may also save you from rewriting large portions depending on feedback from the review.

We will use the same Coding Starndards for this git as in the other OP-TEE gits, but so far we've only done minimal changes compared to the original code. Updates to the code to better follow the coding standards are welcome, but please do it in somewhat small increments and keep it apart from other changes.

Fixing a warning in a small function while fixing the coding style should be OK, but keep in mind that if the change is too large, you may be asked to split it into smaller changes.

[github-actions]

This issue has been marked as a stale issue because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this issue will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

[jenswi-linaro]

Here's one issue that needs to be fixed: #15
I'm afraid it's only the tip of the iceberg.

[jan-kiszka]

I'm down to zero with #17. However, -Wstrict-aliasing is unrealistic to fix without a lot of work in upstream, so I side-stepped this one.

[jenswi-linaro]

We could switch to -fno-strict-aliasing.

[jsetje]

I set -fno-strict-aliasing in a downstream build the other day, and then found this issue when looking for what upstream thought about this. Since I had the patch, I've posted: #23

I also filed microsoft/ms-tpm-20-ref#121