Segmentation fault in refresh_states (set=<optimized out>) at ../atspi/atspi-stateset.c:126

[tbigot]

On the first launch of Knowbridge, I get the icon appearing in the systray. When I right-click on it, I can see the pop-up menu, but as soon as I hover “Settings…”, the program segfaults.

Here is the trace:

#0  0x00007ffff74f5c0c in refresh_states (set=<optimized out>) at ../atspi/atspi-stateset.c:126
#1  atspi_state_set_contains (set=0x5555558b12a0, state=ATSPI_STATE_FOCUSED) at ../atspi/atspi-stateset.c:198
#2  0x000055555556586c in (anonymous namespace)::focus_event_callback(_AtspiEvent*, void*) ()
#3  0x00007ffff74ee09a in _atspi_send_event (e=e@entry=0x7fffffffce90) at ../atspi/atspi-event-listener.c:1096
#4  0x00007ffff74ee51d in _atspi_dbus_handle_event (message=message@entry=0x55555585f0e0) at ../atspi/atspi-event-listener.c:1265
#5  0x00007ffff74f2d98 in process_deferred_message (closure=0x5555557c7310) at ../atspi/atspi-misc.c:915
#6  process_deferred_messages () at ../atspi/atspi-misc.c:967
#7  0x00007ffff74f2f54 in process_deferred_messages () at ../atspi/atspi-misc.c:962
#8  process_deferred_messages_callback (data=data@entry=0x0) at ../atspi/atspi-misc.c:977
#9  0x00007ffff56ffa22 in g_idle_dispatch (source=0x5555557c82c0, callback=0x7ffff74f2f40 <process_deferred_messages_callback>, user_data=0x0) at ../glib/gmain.c:6466
#10 0x00007ffff57018be in g_main_dispatch (context=0x7fffe8000f60) at ../glib/gmain.c:3565
#11 g_main_context_dispatch_unlocked (context=context@entry=0x7fffe8000f60) at ../glib/gmain.c:4425
#12 0x00007ffff5704ca8 in g_main_context_iterate_unlocked (context=context@entry=0x7fffe8000f60, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>)
    at ../glib/gmain.c:4490
#13 0x00007ffff57054e0 in g_main_context_iteration (context=0x7fffe8000f60, may_block=1) at ../glib/gmain.c:4556
#14 0x00007ffff5ce8348 in QEventDispatcherGlib::processEvents (this=0x5555555a60b0, flags=...)
    at /usr/src/debug/qtbase6-6.10.0-2.mga10.x86_64/src/corelib/kernel/qeventdispatcher_glib.cpp:399
#15 0x00007ffff59d6013 in QEventLoop::exec (this=this@entry=0x7fffffffd240, flags=..., flags@entry=...)
    at /usr/src/debug/qtbase6-6.10.0-2.mga10.x86_64/src/corelib/global/qflags.h:77
#16 0x00007ffff59d1855 in QCoreApplication::exec () at /usr/src/debug/qtbase6-6.10.0-2.mga10.x86_64/src/corelib/kernel/qcoreapplication.cpp:1452
#17 0x000055555555ffca in main ()

I’m using the latest commit 2474041, compiled with the docker option.
KDE Plasma 6.5.3 (Wayland)

[tbigot]

This patch seems to fix the issue:

diff --git a/src/AccessibilityHelper.cpp b/src/AccessibilityHelper.cpp
index eced097..a252fd4 100644
--- a/src/AccessibilityHelper.cpp
+++ b/src/AccessibilityHelper.cpp
@@ -74,19 +74,21 @@ namespace { // Anonymous namespace for static callback
         // standard focus events like `Focus:Object` or `Focus:Window`.
         // For `object:state-changed:focused`, let's verify the state.
         AtspiStateSet* stateSet = atspi_accessible_get_state_set(event->source);
-        // <<< FIX 2: Use g_object_unref for AtspiStateSet
-        if (stateSet) {
-            g_object_unref(stateSet); // Free the state set reference
+        if (!stateSet) {
+            qWarning() << "AT-SPI: could not get state set for focused object.";
+            return;
         }
 
-        if (atspi_state_set_contains(stateSet, ATSPI_STATE_FOCUSED)
-            && atspi_state_set_contains(stateSet, ATSPI_STATE_EDITABLE)) {
-            // The source object is now focused.
+        const gboolean isFocused  = atspi_state_set_contains(stateSet, ATSPI_STATE_FOCUSED);
+        const gboolean isEditable = atspi_state_set_contains(stateSet, ATSPI_STATE_EDITABLE);
+
+        g_object_unref(stateSet);
+
+        if (isFocused && isEditable) {
             helper->updateCurrentFocus(event->source);
-        } else if (atspi_state_set_contains(stateSet, ATSPI_STATE_FOCUSED)) {
+        } else if (isFocused) {
             helper->updateCurrentFocus(nullptr); // we don't need other components
         }
-
         // This could be a focus-lost event for this object, ignore for our purpose
         // unless we also want to track focus loss explicitly.
         // NOTE: DO NOT free the event here, the listener machinery does it.
@@ -566,4 +568,4 @@ bool AccessibilityHelper::replaceTextInElement(const ElementInfo& elementInfo, c
     qWarning() << "AT-SPI support is disabled, cannot replace text.";
     return false;
 #endif // HAVE_ATSPI
-}
\ No newline at end of file
+}