History matching and control mode data represented in same objects

[sveinung-r]

WellProductionProperties and WellInjectionProperties are currently representing both history matching and control mode data. This may create some confusion as to the meaning of terms such as BHP, OilRate etc. as these may be limits set for simulation or historic data. Having separate classes would enable inferring the meaning of these terms from context.

Perhaps these should be split in different types representing historic and control mode data separately?

[GitPaean]

Yes. We have discussed in #1032 . Thanks for pointing it out though. We need to address it.

[GitPaean]

We will try to fix it, it also it needs to be fixed from the simulator side and some work in opm-core.