Skip to content

Adjusment to settings schemas #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sambles opened this issue Feb 19, 2025 · 2 comments
Closed

Adjusment to settings schemas #177

sambles opened this issue Feb 19, 2025 · 2 comments
Assignees
Labels

Comments

@sambles
Copy link
Contributor

sambles commented Feb 19, 2025

Requested change:

  • Mark older properties, ones replaced by computation_settings as depreciated (things like pla, and do_disaggregation)
  • The properties which are shared between model_settings and computation_settings to be factored out and merged together using allOF ~ Amir to create an example which oasis will used to create a PR

Future work

  • Clean up the schema from duplicated definitions, these are the same objects being defined in both model_settings and analysis_settings. Instead use a definitions schema which then is used by both. This should help avoid mismatches between these two schemas.
@sambles sambles added enhancement New feature or request LTS - 2.4 labels Feb 19, 2025
@sambles sambles moved this to In Progress in Oasis Dev Team Tasks Feb 19, 2025
@sambles sambles self-assigned this Feb 24, 2025
@sambles
Copy link
Contributor Author

sambles commented Feb 25, 2025

Note: Platform schema description fields might be broken again in v2.4.0

Suggested change: oasis_api-2.4.0-patched2.json

@sambles
Copy link
Contributor Author

sambles commented Mar 5, 2025

done

@sambles sambles closed this as completed Mar 5, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Oasis Dev Team Tasks Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant