From 3552d98ca258cbf0b5f1573d18418243edd2bf49 Mon Sep 17 00:00:00 2001 From: Sam Crauwels Date: Thu, 23 Apr 2026 14:59:31 +0200 Subject: [PATCH] fix(elasticsearch): drop dict-literal default from restart handler conditionals Ansible 2.19 tightened conditional evaluation and now rejects expressions like `default({'changed': false})` inside a `when:` with "Conditional expressions must be strings." Replace the dict-literal default with an attribute-level default, which is semantically equivalent and parses under both 2.18 and 2.19. Closes #139 --- roles/elasticsearch/handlers/main.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/roles/elasticsearch/handlers/main.yml b/roles/elasticsearch/handlers/main.yml index 1ac3d3f..d34a9be 100644 --- a/roles/elasticsearch/handlers/main.yml +++ b/roles/elasticsearch/handlers/main.yml @@ -7,8 +7,8 @@ when: - not ansible_check_mode - elasticsearch_enable | bool - - not (_elasticsearch_freshstart | default({'changed': false})).changed | bool - - not (_elasticsearch_freshstart_security | default({'changed': false})).changed | bool + - not (_elasticsearch_freshstart.changed | default(false) | bool) + - not (_elasticsearch_freshstart_security.changed | default(false) | bool) - not _elasticsearch_rolling_upgrade_performed | default(false) | bool - name: Restart Elasticsearch directly @@ -20,8 +20,8 @@ - > elasticsearch_config_restart_strategy == 'direct' or groups[elasticstack_elasticsearch_group_name] | default([]) | length <= 1 - - not (_elasticsearch_freshstart | default({'changed': false})).changed | bool - - not (_elasticsearch_freshstart_security | default({'changed': false})).changed | bool + - not (_elasticsearch_freshstart.changed | default(false) | bool) + - not (_elasticsearch_freshstart_security.changed | default(false) | bool) - not _elasticsearch_rolling_upgrade_performed | default(false) | bool - name: Clear direct Elasticsearch restart request @@ -34,8 +34,8 @@ - > elasticsearch_config_restart_strategy == 'direct' or groups[elasticstack_elasticsearch_group_name] | default([]) | length <= 1 - - not (_elasticsearch_freshstart | default({'changed': false})).changed | bool - - not (_elasticsearch_freshstart_security | default({'changed': false})).changed | bool + - not (_elasticsearch_freshstart.changed | default(false) | bool) + - not (_elasticsearch_freshstart_security.changed | default(false) | bool) - not _elasticsearch_rolling_upgrade_performed | default(false) | bool - name: Restart Elasticsearch rolling @@ -47,8 +47,8 @@ - elasticsearch_enable | bool - elasticsearch_config_restart_strategy == 'rolling' - groups[elasticstack_elasticsearch_group_name] | default([]) | length > 1 - - not (_elasticsearch_freshstart | default({'changed': false})).changed | bool - - not (_elasticsearch_freshstart_security | default({'changed': false})).changed | bool + - not (_elasticsearch_freshstart.changed | default(false) | bool) + - not (_elasticsearch_freshstart_security.changed | default(false) | bool) - not _elasticsearch_rolling_upgrade_performed | default(false) | bool - name: Restart kibana if available for elasticsearch certificates