Fix schedule-for-route OpenAPI conformance: add missing Stops field

[aaronbrethorst]

Summary

The OpenAPI conformance test is failing for the schedule-for-route endpoint because the response is missing a Stops field that the spec requires.

FAIL: TestOpenAPIConformance_StaticEndpoints/schedule-for-route
Error: Schema violation - property "stops" is missing from schedule-for-route response

What needs to change

1. Model (internal/models/schedule_for_route.go): Add a Stops field to the ScheduleForRouteEntry struct
2. Handler (internal/restapi/schedule_for_route_handler.go): Populate the stops list in the response, collecting all stops referenced by the route's schedule

Existing pattern to follow

The stops_for_route_handler.go (lines ~146-199) already builds a stop list for a route — the same pattern of collecting stop IDs, querying them, and converting to model objects applies here.

Acceptance criteria

• ScheduleForRouteEntry includes a Stops field with proper JSON tag
• The handler populates stops from the route's schedule data
• TestOpenAPIConformance_StaticEndpoints/schedule-for-route passes
• Existing tests in schedule_for_route_handler_test.go continue to pass
• make test passes
• make lint passes

References

• OpenAPI spec: https://github.com/OneBusAway/sdk-config/blob/main/openapi.yml
• API docs: https://developer.onebusaway.org/api/where/methods/schedule-for-route

[ARCoder181105]

New contributors U all are open to work on this PR

[Adityatorgal17]

@aaronbrethorst I did my analysis and found that https://github.com/OneBusAway/sdk-config/blob/main/openapi.yml ScheduleEntry schema contains only these 4 fields:-

routeId
scheduleDate
serviceIds
stopTripGroupings

But maglev/testdata/openapi.yml still had two extra fields: trips and stops.

The change in 02b8cb2 removed those fields from ScheduleForRouteEntry in internal/models/schedule_for_route.go, so handler output no longer includes them. Tests were passing before because this mismatch was not being validated. Once OpenAPI conformance validation ran, it compared response payloads against testdata/openapi.yml and failed on missing stops/trips.

So the fix is to align maglev/testdata/openapi.yml ScheduleEntry with current API output (remove stops and trips from both properties and required).

Also adding stops and trips back to ScheduleForRouteEntry/handler would effectively reverse that earlier change 02b8cb2

I fixed this by updating testdata/openapi.yml to match the current ScheduleEntry response shape, and I’ve opened a PR for it #700