Use redirectTo method and change default redirect to the welcome page

Author: avvertix

src/Auth/RedirectsUsers.php

@@ -10,15 +10,13 @@ trait RedirectsUsers
 {
     /**
      * Get the post register / login redirect path.
-     *
-     * @return string
      */
-    public function redirectPath()
+    public function redirectPath(): string
     {
         if (method_exists($this, 'redirectTo')) {
             return $this->redirectTo();
         }
 
-        return property_exists($this, 'redirectTo') ? $this->redirectTo : '/home';
+        return property_exists($this, 'redirectTo') ? $this->redirectTo : '/';
     }
 }

stubs/Identities/Auth/ConnectController.stub

@@ -4,7 +4,6 @@ namespace App\Http\Controllers\Identities\Auth;
 
 use App\User;
 use App\Http\Controllers\Controller;
-use App\Providers\RouteServiceProvider;
 use Oneofftech\Identities\Auth\ConnectUserIdentity;
 
 class ConnectController extends Controller
@@ -25,18 +24,9 @@ class ConnectController extends Controller
 
     /**
      * Where to redirect users after connection.
-     *
-     * @var string
      */
-    protected $redirectTo = RouteServiceProvider::HOME;
-
-    /**
-     * Create a new controller instance.
-     *
-     * @return void
-     */
-    public function __construct()
+    protected function redirectTo(): string
     {
-        $this->middleware('auth');
+        return '/';
     }
 }

stubs/Identities/Auth/LoginController.stub

@@ -3,7 +3,6 @@
 namespace App\Http\Controllers\Identities\Auth;
 
 use App\Http\Controllers\Controller;
-use App\Providers\RouteServiceProvider;
 use Oneofftech\Identities\Auth\AuthenticatesUsersWithIdentity;
 
 class LoginController extends Controller
@@ -24,18 +23,9 @@ class LoginController extends Controller
 
     /**
      * Where to redirect users after login.
-     *
-     * @var string
      */
-    protected $redirectTo = RouteServiceProvider::HOME;
-
-    /**
-     * Create a new controller instance.
-     *
-     * @return void
-     */
-    public function __construct()
+    protected function redirectTo(): string
     {
-        $this->middleware('guest');
+        return '/';
     }
 }

stubs/Identities/Auth/RegisterController.stub

@@ -6,7 +6,6 @@ use App\User;
 use Illuminate\Support\Str;
 use App\Http\Controllers\Controller;
 use Illuminate\Support\Facades\Hash;
-use App\Providers\RouteServiceProvider;
 use Illuminate\Support\Facades\Validator;
 use Oneofftech\Identities\Auth\RegistersUsersWithIdentity;
 
@@ -27,19 +26,10 @@ class RegisterController extends Controller
 
     /**
      * Where to redirect users after registration.
-     *
-     * @var string
-     */
-    protected $redirectTo = RouteServiceProvider::HOME;
-
-    /**
-     * Create a new controller instance.
-     *
-     * @return void
      */
-    public function __construct()
+    protected function redirectTo(): string
     {
-        $this->middleware('guest');
+        return '/';
     }
 
     /**

tests/Unit/ConnectControllerTest.php

@@ -93,7 +93,7 @@ public function test_connect_creates_identity()
         $response = $this->actingAs($user)
             ->get(route('oneofftech::connect.callback', ['provider' => 'gitlab']));
 
-        $response->assertRedirect('http://localhost/home');
+        $response->assertRedirect('http://localhost');
 
         $updatedIdentity = $user->identities->first();
 
@@ -144,7 +144,7 @@ public function test_connect_updates_existing_identity()
         $response = $this->actingAs($user)
             ->get(route('oneofftech::connect.callback', ['provider' => 'gitlab']));
 
-        $response->assertRedirect('http://localhost/home');
+        $response->assertRedirect('http://localhost');
 
         $updatedIdentity = $user->identities->first();
 

tests/Unit/LoginControllerTest.php

@@ -67,7 +67,7 @@ public function test_user_login()
 
         $response = $this->get(route('oneofftech::login.callback', ['provider' => 'gitlab']));
 
-        $response->assertRedirect('http://localhost/home');
+        $response->assertRedirect('http://localhost');
 
         $this->assertAuthenticatedAs($user);
     }

tests/Unit/RegistrationControllerTest.php

@@ -56,7 +56,7 @@ public function test_user_can_be_registered()
 
         $response = $this->get(route('oneofftech::register.callback', ['provider' => 'gitlab']));
 
-        $response->assertRedirect('http://localhost/home');
+        $response->assertRedirect('http://localhost');
 
         $user = User::first();