Q1

Author: moe18

questions/1_matrix-vector-dot-product/tinygrad/solution.py

@@ -1,13 +1,11 @@
 from tinygrad.tensor import Tensor
 
-def matrix_dot_vector_tg(a, b) -> Tensor:
+def matrix_dot_vector_tg(a: Tensor, b: Tensor) -> Tensor:
     """
     Compute the product of matrix `a` and vector `b` using tinygrad.
-    Inputs can be Python lists, NumPy arrays, or tinygrad Tensors.
+    Inputs will be tinygrad Tensors.
     Returns a 1-D Tensor of length m, or Tensor(-1) if dimensions mismatch.
     """
     if len(a[0]) != len(b):
         return Tensor(-1)
-    a_t = Tensor(a)
-    b_t = Tensor(b)
-    return a_t.matmul(b_t)
+    return a @ b

questions/1_matrix-vector-dot-product/tinygrad/starter_code.py

@@ -1,16 +1,9 @@
 from tinygrad.tensor import Tensor
 
-def matrix_dot_vector_tg(a, b) -> Tensor:
+def matrix_dot_vector_tg(a:Tensor, b:Tensor) -> Tensor:
     """
     Compute the product of matrix `a` and vector `b` using tinygrad.
-    Inputs can be Python lists, NumPy arrays, or tinygrad Tensors.
+    Will be tinygrad Tensors.
     Returns a 1-D Tensor of length m, or Tensor(-1) if dimensions mismatch.
     """
-    # Dimension mismatch check
-    if len(a[0]) != len(b):
-        return Tensor(-1)
-    # Convert to Tensor
-    a_t = Tensor(a)
-    b_t = Tensor(b)
-    # Your implementation here
     pass

questions/1_matrix-vector-dot-product/tinygrad/tests.json

@@ -1,10 +1,14 @@
 [
   {
-    "test": "from tinygrad.tensor import Tensor\nres = matrix_dot_vector_tg(\n    [[1,2,3],[2,4,5],[6,8,9]],\n    [1,2,3]\n)\nprint(res.numpy().tolist())",
+    "test": "from tinygrad.tensor import Tensor\nres = matrix_dot_vector_tg(\n    Tensor([[1,2,3],[2,4,5],[6,8,9]]),\n    Tensor([1,2,3])\n)\nprint(res.numpy().tolist())",
     "expected_output": "[14.0, 25.0, 49.0]"
   },
   {
-    "test": "from tinygrad.tensor import Tensor\nres = matrix_dot_vector_tg(\n    [[1,2,3],[2,4,5]],\n    [1,2]\n)\nprint(res.numpy().tolist())",
+    "test": "from tinygrad.tensor import Tensor\nres = matrix_dot_vector_tg(\n    Tensor([[1,2,3],[2,4,5]]),\n    Tensor([1,2])\n)\nprint(res.numpy().tolist())",
     "expected_output": "-1"
+  },
+  {
+    "test": "from tinygrad.tensor import Tensor\nres = matrix_dot_vector_tg(\n    Tensor([[1, 2], [2, 4]]),\n    Tensor([1, 2])\n)\nprint(res.numpy().tolist())",
+    "expected_output": "[5, 10]"
   }
 ]