Broken .to_csv function

[Postiii]

Description of the issue

When using the mastr.py, I do receive an error when calling the to_csv() function after upgrading from v0.16.1 to v0.17.0:

NameError: name 'kwargs' is not defined

It refers to mastr.py line 287:
https://github.com/OpenEnergyPlatform/open-MaStR/blob/develop/open_mastr/mastr.py#L287

Steps to Reproduce

Just bulk download and use to_csv with version 0.17.0.

Ideas of solution

In comparison to „download“ function, to_csv function has no parameter **kwargs when calling the function.

Context and Environment

• Version used: v0.17.0
• Operating system: Linux
• Environment setup and (python) version: Databricks, Spark 17.3x-scala2.13 (python 3.12.3)

Workflow checklist

• I have checked the documentation and confirmed this issue is not already addressed there.
• I am aware of the workflow in CONTRIBUTING.md

[FlorianK13]

@Postiii thanks for your issue, I think this slipped through during our release. @Simon-Will does it make sense to release the simplified .to_csv earlier?

[FlorianK13]

One note: the schema of the csv files will change in the future, ie we might not merge tables anymore. In the future we will probably export the database as is. This is described here: #661

[Simon-Will]

@FlorianK13, I think I'd prefer fixing the to_csv in a 0.17.1 release. For that I opened #736. Is that alright with you?

[FlorianK13]

@Simon-Will back from short holiday, I'll take a look now.

[Simon-Will]

The fix will be in the 0.17.1 release, but as Florian said above: The to_csv function will massively change in 1.0.0: We will directly export the tables as they are instead of merging tables like _eeg and _extended.