From fdfeb9383c6274031e608b78b46b62c556fc5d87 Mon Sep 17 00:00:00 2001 From: Ethan Holz Date: Fri, 23 Jan 2026 17:12:02 -0700 Subject: [PATCH 1/3] feat: return namespaced handles so other untis can ingest these handles --- gufe/storage/storagemanager.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gufe/storage/storagemanager.py b/gufe/storage/storagemanager.py index 5b0971b0..2a7a76f2 100644 --- a/gufe/storage/storagemanager.py +++ b/gufe/storage/storagemanager.py @@ -67,15 +67,21 @@ def append_to_namespace(namespace: str, filename: str) -> str: # We opt _not_ to use Paths because these aren't actually path objects return f"{namespace}/{filename}" - def register(self, filename: str): + def register(self, filename: str) -> str: """Register a filename for later transfer to external storage. Parameters ---------- filename : str The filename to register for transfer. + + Returns + ------- + str + The globaly namespaced path used by other units """ self.registry.add(filename) + return self.append_to_namespace(self.namespace, filename) def load(self, filename: str) -> bytes: """Load an item from external storage. From 8f68d0311f5119c0630e6d86d4a5026b81592569 Mon Sep 17 00:00:00 2001 From: Ethan Holz Date: Fri, 23 Jan 2026 17:12:25 -0700 Subject: [PATCH 2/3] test: add a test to validate --- gufe/tests/storage/test_storagemanager.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gufe/tests/storage/test_storagemanager.py b/gufe/tests/storage/test_storagemanager.py index 8eca4a08..89842dea 100644 --- a/gufe/tests/storage/test_storagemanager.py +++ b/gufe/tests/storage/test_storagemanager.py @@ -80,7 +80,8 @@ def test_register(self, storage_manager): assert filename not in storage_manager # Register the file - storage_manager.register(filename) + out = storage_manager.register(filename) + assert out == storage_manager.append_to_namespace(storage_manager.namespace, filename) # Check it's now in the registry assert filename in storage_manager.registry From 122dca14eb9c34b664b12b720c038f4e0f855538 Mon Sep 17 00:00:00 2001 From: Ethan Holz Date: Wed, 28 Jan 2026 07:10:05 -0700 Subject: [PATCH 3/3] Update gufe/storage/storagemanager.py Co-authored-by: Alyssa Travitz <31974495+atravitz@users.noreply.github.com> --- gufe/storage/storagemanager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gufe/storage/storagemanager.py b/gufe/storage/storagemanager.py index 2a7a76f2..4ba4c7a0 100644 --- a/gufe/storage/storagemanager.py +++ b/gufe/storage/storagemanager.py @@ -78,7 +78,7 @@ def register(self, filename: str) -> str: Returns ------- str - The globaly namespaced path used by other units + The globally namespaced path to be used by other units """ self.registry.add(filename) return self.append_to_namespace(self.namespace, filename)