Compile, Bump version, Update changelog and contributing guide to include eslint changes

Author: jeremiahrhall

CHANGELOG.md

@@ -1,3 +1,11 @@
+# 0.2.4 Release
+- List eslint as an explicit devDependency
+- upgrade the eslint related packages
+- fix linting errors using current config
+- Add notes about maintaining absence of lint errors and warnings in Contributing guide
+- This should make it easier to ensure code quality as others contribute in the open
+- Also, drop unused jest and enzyme deps
+
 # 0.2.3 Release
 - Missed Transpilation
 

CONTRIBUTING.md

@@ -56,6 +56,7 @@ Before submitting a Pull Request please ensure you have completed the following
 2. Make sure your copy is up to date: `git pull upstream master`
 3. Run `npm run compile`, to compile your changes to the exported `/lib` code.
 4. Bump the version in `package.json` as appropriate, see `Versioning` in the section below.
+4. Run `npm run lint` to verify code style, all pull requests should have zero lint errors and warnings
 4. Commit your changes
 5. Push your changes to your fork: `your-username/react-leaflet-heatmap-layer`
 6. Open a pull request from your fork to the `upstream` fork (`OpenGov/react-leaflet-heatmap-layer`)

lib/HeatmapLayer.js

@@ -20,30 +20,22 @@ var _lodash3 = require('lodash.reduce');
 
 var _lodash4 = _interopRequireDefault(_lodash3);
 
-var _lodash5 = require('lodash.foreach');
+var _lodash5 = require('lodash.filter');
 
 var _lodash6 = _interopRequireDefault(_lodash5);
 
-var _lodash7 = require('lodash.pluck');
+var _lodash7 = require('lodash.min');
 
 var _lodash8 = _interopRequireDefault(_lodash7);
 
-var _lodash9 = require('lodash.filter');
+var _lodash9 = require('lodash.max');
 
 var _lodash10 = _interopRequireDefault(_lodash9);
 
-var _lodash11 = require('lodash.min');
+var _lodash11 = require('lodash.isnumber');
 
 var _lodash12 = _interopRequireDefault(_lodash11);
 
-var _lodash13 = require('lodash.max');
-
-var _lodash14 = _interopRequireDefault(_lodash13);
-
-var _lodash15 = require('lodash.isnumber');
-
-var _lodash16 = _interopRequireDefault(_lodash15);
-
 var _leaflet = require('leaflet');
 
 var _leaflet2 = _interopRequireDefault(_leaflet);
@@ -62,20 +54,20 @@ function _possibleConstructorReturn(self, call) { if (!self) { throw new Referen
 
 function _inherits(subClass, superClass) { if (typeof superClass !== "function" && superClass !== null) { throw new TypeError("Super expression must either be null or a function, not " + typeof superClass); } subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } }); if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass; }
 
-function isValidLatLngArray(arr) {
-  return (0, _lodash10.default)(arr, isValid).length === arr.length;
+function isInvalid(num) {
+  return !(0, _lodash12.default)(num) && !num;
 }
 
-function isInvalidLatLngArray(arr) {
-  return !isValidLatLngArray(arr);
+function isValid(num) {
+  return !isInvalid(num);
 }
 
-function isInvalid(num) {
-  return !(0, _lodash16.default)(num) && !num;
+function isValidLatLngArray(arr) {
+  return (0, _lodash6.default)(arr, isValid).length === arr.length;
 }
 
-function isValid(num) {
-  return !isInvalid(num);
+function isInvalidLatLngArray(arr) {
+  return !isValidLatLngArray(arr);
 }
 
 function shouldIgnoreLocation(loc) {
@@ -162,8 +154,8 @@ var HeatmapLayer = function (_MapLayer) {
     var points = this.props.points;
     var lngs = (0, _lodash2.default)(points, this.props.longitudeExtractor);
     var lats = (0, _lodash2.default)(points, this.props.latitudeExtractor);
-    var ne = { lng: (0, _lodash14.default)(lngs), lat: (0, _lodash14.default)(lats) };
-    var sw = { lng: (0, _lodash12.default)(lngs), lat: (0, _lodash12.default)(lats) };
+    var ne = { lng: (0, _lodash10.default)(lngs), lat: (0, _lodash10.default)(lats) };
+    var sw = { lng: (0, _lodash8.default)(lngs), lat: (0, _lodash8.default)(lats) };
 
     if (shouldIgnoreLocation(ne) || shouldIgnoreLocation(sw)) {
       return;
@@ -187,15 +179,15 @@ var HeatmapLayer = function (_MapLayer) {
   HeatmapLayer.prototype.attachEvents = function attachEvents() {
     var _this2 = this;
 
-    var map = this.props.map;
-    map.on('viewreset', function () {
+    var leafletMap = this.props.map;
+    leafletMap.on('viewreset', function () {
       return _this2.reset();
     });
-    map.on('moveend', function () {
+    leafletMap.on('moveend', function () {
       return _this2.reset();
     });
-    if (map.options.zoomAnimation && _leaflet2.default.Browser.any3d) {
-      map.on('zoomanim', this._animateZoom, this);
+    if (leafletMap.options.zoomAnimation && _leaflet2.default.Browser.any3d) {
+      leafletMap.on('zoomanim', this._animateZoom, this);
     }
   };
 
@@ -241,7 +233,6 @@ var HeatmapLayer = function (_MapLayer) {
     var v = 1 / Math.pow(2, Math.max(0, Math.min(maxZoom - this.props.map.getZoom(), 12)));
 
     var cellSize = r / 2;
-    var grid = [];
     var panePos = this.props.map._getMapPanePos();
     var offsetX = panePos.x % cellSize;
     var offsetY = panePos.y % cellSize;
@@ -253,15 +244,15 @@ var HeatmapLayer = function (_MapLayer) {
       return bounds.contains(p);
     };
 
-    var filterUndefined = function filterUndefined(r) {
-      return (0, _lodash10.default)(r, function (c) {
+    var filterUndefined = function filterUndefined(row) {
+      return (0, _lodash6.default)(row, function (c) {
         return c !== undefined;
       });
     };
 
     var roundResults = function roundResults(results) {
       return (0, _lodash4.default)(results, function (result, row) {
-        return (0, _lodash2.default)(filterUndefined(row), function (cell, key, row) {
+        return (0, _lodash2.default)(filterUndefined(row), function (cell) {
           return [Math.round(cell[0]), Math.round(cell[1]), Math.min(cell[2], maxIntensity), cell[3]];
         }).concat(result);
       }, []);
@@ -303,7 +294,7 @@ var HeatmapLayer = function (_MapLayer) {
       }, []);
     };
 
-    var getBounds = function getBounds(leafletMap) {
+    var getBounds = function getBounds() {
       return new _leaflet2.default.Bounds(_leaflet2.default.point([-r, -r]), size.add([r, r]));
     };
 
@@ -318,13 +309,11 @@ var HeatmapLayer = function (_MapLayer) {
     this._frame = null;
 
     if (this.props.onStatsUpdate && this.props.points && this.props.points.length > 0) {
-      var stats = _.reduce(data, function (stats, point) {
+      this.props.onStatsUpdate((0, _lodash4.default)(data, function (stats, point) {
         stats.max = point[3] > stats.max ? point[3] : stats.max;
         stats.min = point[3] < stats.min ? point[3] : stats.min;
         return stats;
-      }, { min: Infinity, max: -Infinity });
-
-      this.props.onStatsUpdate(stats);
+      }, { min: Infinity, max: -Infinity }));
     }
   };
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-leaflet-heatmap-layer",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "A custom layer for heatmaps in react-leaflet",
   "main": "lib/HeatmapLayer.js",
   "scripts": {