From 9d452a0ec9c3f7447a9a56a8b046471603420392 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Droz?= Date: Mon, 15 Sep 2025 18:11:45 -0300 Subject: [PATCH 1/3] ci: upload artifacts --- .github/workflows/build.yml | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4d63f82..4dae9b9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -5,21 +5,24 @@ on: [push, pull_request] jobs: build: runs-on: ubuntu-22.04 + name: NGINX v${{ matrix.nginx_version }} + + strategy: + matrix: + nginx_version: [1.18.0, 1.24.0, 1.26.2, 1.27.3] steps: - uses: actions/checkout@v3 - name: Dependencies - env: - NGINX_VERSION: 1.18.0 run: | sudo apt-get update -y sudo apt-get install -y libssl-dev libcurl4-openssl-dev libhiredis-dev libmemcached-dev sudo apt-get install -y libjansson-dev libcjose-dev apache2-dev pkg-config cd /tmp - wget https://nginx.org/download/nginx-${NGINX_VERSION}.tar.gz - tar zxvf nginx-${NGINX_VERSION}.tar.gz - ln -s nginx-${NGINX_VERSION} nginx + wget https://nginx.org/download/nginx-${{ matrix.nginx_version }}.tar.gz + tar zxvf nginx-${{ matrix.nginx_version }}.tar.gz + ln -s nginx-${{ matrix.nginx_version }} nginx cd /tmp/nginx && ./configure --with-debug cd /tmp git clone https://github.com/OpenIDC/liboauth2.git @@ -36,5 +39,17 @@ jobs: - name: Make run: make + - name: Dist + # Add build/{include,lib} inside folder (eg: ngx_oauth2_module-4.0.0/) which is going to be uploaded + run: | + make distdir prefix=/build + make install prefix=/build DESTDIR=$(pwd)/'$(PACKAGE_NAME)-$(PACKAGE_VERSION)' + + - name: Upload artifacts + uses: actions/upload-artifact@v4 + with: + name: ngx_oauth2_module-${{ matrix.nginx_version }} + path: ngx_oauth2_module-* + - name: Distcheck run: make distcheck DESTDIR="/tmp/ngx_oauth2_module" DISTCHECK_CONFIGURE_FLAGS="--with-nginx=/tmp/nginx" From 0914f3b77662efad434228da73f35230aac91c6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Droz?= Date: Mon, 15 Sep 2025 18:38:15 -0300 Subject: [PATCH 2/3] use the latest 1.26.x version, added 1.28.0 --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4dae9b9..6b79bb7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,7 +9,7 @@ jobs: strategy: matrix: - nginx_version: [1.18.0, 1.24.0, 1.26.2, 1.27.3] + nginx_version: [1.18.0, 1.24.0, 1.26.3, 1.27.3, 1.28.0] steps: - uses: actions/checkout@v3 From 059e52889d50a35df89a3e29413d7db0729200ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Droz?= Date: Mon, 15 Sep 2025 19:16:50 -0300 Subject: [PATCH 3/3] added --with-compat to avoid possible segfaults when nginx compile-time flags differ too much with runtime --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6b79bb7..bfb2744 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -23,7 +23,7 @@ jobs: wget https://nginx.org/download/nginx-${{ matrix.nginx_version }}.tar.gz tar zxvf nginx-${{ matrix.nginx_version }}.tar.gz ln -s nginx-${{ matrix.nginx_version }} nginx - cd /tmp/nginx && ./configure --with-debug + cd /tmp/nginx && ./configure --with-debug --with-compat cd /tmp git clone https://github.com/OpenIDC/liboauth2.git cd liboauth2