cmake: Fix MSVC warnings

Author: xlz

CMakeLists.txt

@@ -27,6 +27,13 @@ OPTION(ENABLE_CXX11 "Enable C++11 support" OFF)
 OPTION(ENABLE_OPENCL "Enable OpenCL support" ON)
 OPTION(ENABLE_OPENGL "Enable OpenGL support" ON)
 
+IF(MSVC)
+  # suppress several "possible loss of data" warnings, and
+  # "zero-length array in struct" from libusb.h
+  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4267 /wd4244 /wd4200 /wd4305 /wd4146")
+  ADD_DEFINITIONS(-D_CRT_SECURE_NO_WARNINGS) # no warning for getenv()
+ENDIF()
+
 IF(ENABLE_CXX11)
   INCLUDE(CheckCXXCompilerFlag)
   CHECK_CXX_COMPILER_FLAG("-std=c++11" COMPILER_SUPPORTS_CXX11)

include/internal/libfreenect2/logging.h

@@ -66,7 +66,7 @@ std::string getShortName(const char *func);
 
 } /* namespace libfreenect2 */
 
-#if defined(__GNUC__) or defined(__clang__)
+#if defined(__GNUC__) || defined(__clang__)
 #define LOG_SOURCE ::libfreenect2::getShortName(__PRETTY_FUNCTION__)
 #elif defined(_MSC_VER)
 #define LOG_SOURCE ::libfreenect2::getShortName(__FUNCSIG__)

src/opengl_depth_packet_processor.cpp

@@ -387,8 +387,9 @@ struct Texture : public WithOpenGLBindings
   }
 };
 
-struct OpenGLDepthPacketProcessorImpl : public WithOpenGLBindings, public WithPerfLogging
+class OpenGLDepthPacketProcessorImpl : public WithOpenGLBindings, public WithPerfLogging
 {
+public:
   GLFWwindow *opengl_context_ptr;
   libfreenect2::DepthPacketProcessor::Config config;