Skip to content

Commit cfa3b0e

Browse files
committed
logging: Improve packet loss messages
Avoid flooding of packet loss messages on Windows because the console is very slow. Fix packet loss counting.
1 parent 6a83286 commit cfa3b0e

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

examples/Protonect.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,13 @@ int main(int argc, char *argv[])
9393
}
9494

9595
libfreenect2::Freenect2 freenect2;
96+
#if defined(WIN32) || defined(_WIN32) || defined(__WIN32__)
97+
// avoid flooing the very slow Windows console with debug messages
98+
libfreenect2::setGlobalLogger(libfreenect2::createConsoleLogger(libfreenect2::Logger::Info));
99+
#else
96100
// create a console logger with debug level (default is console logger with info level)
97101
libfreenect2::setGlobalLogger(libfreenect2::createConsoleLogger(libfreenect2::Logger::Debug));
102+
#endif
98103
MyFileLogger *filelogger = new MyFileLogger(getenv("LOGFILE"));
99104
if (filelogger->good())
100105
libfreenect2::setGlobalLogger(filelogger);

src/depth_packet_stream_parser.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ void DepthPacketStreamParser::onDataReceived(unsigned char* buffer, size_t in_le
119119
processed_packets_ = current_sequence_;
120120
int diff = current_sequence_ - processed_packets_;
121121
const int interval = 30;
122-
if (current_sequence_ % interval == 0 && diff != 0)
122+
if ((current_sequence_ % interval == 0 && diff != 0) || diff >= interval)
123123
{
124-
LOG_INFO << diff << " of " << interval << " packets were lost";
124+
LOG_INFO << diff << " packets were lost";
125125
processed_packets_ = current_sequence_;
126126
}
127127
}

src/rgb_packet_stream_parser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ void RgbPacketStreamParser::onDataReceived(unsigned char* buffer, size_t length)
157157
}
158158
else
159159
{
160-
LOG_WARNING << "skipping rgb packet!";
160+
LOG_DEBUG << "skipping rgb packet!";
161161
}
162162

163163
// reset front buffer

0 commit comments

Comments
 (0)