VM configuration incomplete when is added Single VM Backup configuration

[Franco-Sparrow]

Description

VM configuration is incomplete after add Single VM Backup configuratio. The addition of Single VM Backups removes part of the VM configuration template, leading to Client error when connecting to VNC.

To Reproduce

1-Download an apps from the marketplace.
2-Instantiate a VM using the new created template, from the downloaded app.
3-Check the VM config:

onevm updateconf <vmid>

Example output:

OS=[
  ARCH="x86_64",
  UUID="544b2dca-6e06-4d76-8f7b-1bc11e2404c9" ]
FEATURES=[
  ACPI="yes" ]
GRAPHICS=[
  LISTEN="0.0.0.0",
  PORT="5910",
  TYPE="VNC" ]
CONTEXT=[
  DISK_ID="1",
  NETWORK="YES",
  PASSWORD="",
  SET_HOSTNAME="ubu22_N1",
  SSH_PUBLIC_KEY="",
  TARGET="hda" ]

4-Configure Single VM Backup on the new created VM (Backup config is now outside the Update VM Configuration). After configure the SIngle VM Backup, the VM configuration lost part of its original configuration.

onevm updateconf <vmid>

Example output:

CONTEXT=[
  DISK_ID="1",
  NETWORK="YES",
  PASSWORD="",
  SET_HOSTNAME="ubu22_N1",
  SSH_PUBLIC_KEY="",
  TARGET="hda" ]
BACKUP_CONFIG=[
  BACKUP_VOLATILE="NO",
  FS_FREEZE="NONE",
  INCREMENTAL_BACKUP_ID="-1",
  INCREMENT_MODE="CBT",
  LAST_INCREMENT_ID="-1",
  MODE="FULL" ]

The missing configuration from the VM is:

OS=[
  ARCH="x86_64",
  UUID="544b2dca-6e06-4d76-8f7b-1bc11e2404c9" ]
FEATURES=[
  ACPI="yes" ]
GRAPHICS=[
  LISTEN="0.0.0.0",
  PORT="5910",
  TYPE="VNC" ]

This lead to broken VNC.

Expected behavior
After configure Single VM Backup, the VM configuration should keep original configuration PLUS the backup configuration.

NOTE

It works with BackupJobs. It does not add the backup configuration to the VM, now it just add the bkjob id to the VM configuration, and the bkjob has the backup configuration for all members of the bkjob.

Details

• Affected Component: [FSunstone]
• Hypervisor: [KVM]
• Version: [6.10.4]

Additional context
Add any other context about the problem here.

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)

[Franco-Sparrow]

Hi @rsmontero and @vichansson

Another backup issue found. I know that Bkjob is more efficient, but until Bkjob have Reset backup, Single VM Backup is still required to reset the backup chain. The issue is probably on FSunstone.

Beside...KEEP_LAST is missing from Single VM Backup configuration....probably another issue?

[vichansson]

Hi @Franco-Sparrow !

Thanks for reporting on this, just verified it myself and it does indeed overwrite the existing VM configuration when the backup configuration is invoked from the Sunstone VM->Backup tab. This is due to a missing "replace/merge" flag in the API call, currently it's defaulting to replacing all values at the root, will be fixed for the next maintenance release!

Regards,
Victor

[Franco-Sparrow]

Thanks @vichansson

Also, when the Backup config was added, I saw that KEEP_LAST was not present, but it was indeed added to the Bkjob config, so it means that I still in use by the code. You might check this as well, why is not being addes to the Backup config on the Single VM Backup.

Cheers

[dcarracedo]

Check #6860 at the same time that this issue