fix: address PR #49 review feedback #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattapperson
force-pushed
the
fix/pr49-feedback
branch
3 times, most recently
from
bf22cc5 to
94729c3
Compare
- Add type guard for safer response type checking - Refactor IIFE patterns in getMessage/getText to private helper methods - Add braces to single-line if statement for readability - Add validation before assigning finalResponse - Implement parallel tool calling with Promise.allSettled for better error handling
mattapperson
force-pushed
the
fix/pr49-feedback
branch
from
94729c3 to
ed59cd1
Compare
louisgv
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses feedback from louisgv on PR #49.
Changes
npxwithpnpm dlxfor consistency with pnpm package managerisNonStreamingResponsetype guard to replace unsafe type castsgetMessage()andgetText()to cleaner private helper methodsRelated