[FIX] override create an write functions

Author: emjay0921

spp_custom_fields_ui/models/custom_fields_ui.py

@@ -1,6 +1,7 @@
 # Part of OpenSPP. See LICENSE file for full copyright and licensing details.
 
 from odoo import api, fields, models
+from odoo.exceptions import UserError
 
 FIELD_TYPES = [(key, key) for key in sorted(fields.Field.by_type)]
 
@@ -118,3 +119,33 @@ def set_compute(self):
                 else:
                     rec.ttype = "integer"
                     rec.compute += "self.compute_count_and_set_indicator('%s', kinds, domain)" % name
+
+    def _should_reload_view(self):
+        """
+        Check if the view should be reloaded after creating/updating custom fields.
+        This is needed because custom fields modify the model registry.
+        """
+        return any(record.target_type for record in self)
+
+    @api.model_create_multi
+    def create(self, vals_list):
+        """Override create to trigger page reload after field creation"""
+        records = super().create(vals_list)
+        # Trigger reload only for custom fields with target_type in UI context
+        if self.env.context.get("params") and records._should_reload_view():
+            return {
+                "type": "ir.actions.client",
+                "tag": "reload",
+            }
+        return records
+
+    def write(self, vals):
+        """Override write to trigger page reload after field update"""
+        result = super().write(vals)
+        # Trigger reload only for custom fields with target_type in UI context
+        if self.env.context.get("params") and self._should_reload_view():
+            return {
+                "type": "ir.actions.client",
+                "tag": "reload",
+            }
+        return result

spp_custom_fields_ui/tests/test_custom_fields_ui.py

@@ -196,3 +196,90 @@ def test_09_set_compute_error_on_type_change(self):
             "Changing the type of a field is not yet supported",
         ):
             field.set_compute()
+
+    def test_10_create_with_ui_context_returns_reload_action(self):
+        """Test that create with UI context returns reload action"""
+        # Simulate UI context with params
+        context = {"params": {"model": "ir.model.fields", "view_type": "form"}}
+        result = (
+            self.field_model.with_context(context)
+            .create(
+                {
+                    "name": "x_cst_grp_reload_test",
+                    "model_id": self.model_id.id,
+                    "field_description": "Reload Test",
+                    "ttype": "char",
+                    "state": "manual",
+                    "target_type": "grp",
+                    "field_category": "cst",
+                }
+            )
+        )
+
+        # When created in UI context with target_type, should return reload action
+        self.assertIsInstance(result, dict)
+        self.assertEqual(result.get("type"), "ir.actions.client")
+        self.assertEqual(result.get("tag"), "reload")
+
+    def test_11_create_without_ui_context_returns_recordset(self):
+        """Test that create without UI context returns normal recordset"""
+        # Create without params in context (programmatic call)
+        result = self.field_model.create(
+            {
+                "name": "x_cst_grp_no_reload",
+                "model_id": self.model_id.id,
+                "field_description": "No Reload Test",
+                "ttype": "char",
+                "state": "manual",
+                "target_type": "grp",
+                "field_category": "cst",
+            }
+        )
+
+        # Should return recordset, not action dict
+        self.assertEqual(result._name, "ir.model.fields")
+        self.assertTrue(result.id)
+
+    def test_12_write_with_ui_context_returns_reload_action(self):
+        """Test that write with UI context returns reload action"""
+        field = self.field_model.create(
+            {
+                "name": "x_cst_grp_write_test",
+                "model_id": self.model_id.id,
+                "field_description": "Write Test",
+                "ttype": "char",
+                "state": "manual",
+                "target_type": "grp",
+                "field_category": "cst",
+            }
+        )
+
+        # Update with UI context
+        context = {"params": {"model": "ir.model.fields", "view_type": "form"}}
+        result = field.with_context(context).write({"field_description": "Updated Description"})
+
+        # Should return reload action
+        self.assertIsInstance(result, dict)
+        self.assertEqual(result.get("type"), "ir.actions.client")
+        self.assertEqual(result.get("tag"), "reload")
+
+    def test_13_write_without_ui_context_returns_boolean(self):
+        """Test that write without UI context returns boolean"""
+        field = self.field_model.create(
+            {
+                "name": "x_cst_grp_write_no_reload",
+                "model_id": self.model_id.id,
+                "field_description": "Write No Reload",
+                "ttype": "char",
+                "state": "manual",
+                "target_type": "grp",
+                "field_category": "cst",
+            }
+        )
+
+        # Update without UI context (programmatic call)
+        result = field.write({"field_description": "Updated Without Reload"})
+
+        # Should return boolean True
+        self.assertTrue(result)
+        self.assertIsInstance(result, bool)