[UPD] spp_registry_name_suffix: simplify exclusion to boolean is_generational field

Replace exclusion_group (Char) with is_generational (Boolean) to prevent
typographical errors in configuration. Generational suffixes (Jr., Sr.,
I-XV) are now marked with a simple checkbox, and the constraint ensures
only one generational suffix can be selected per individual.

Author: gonzalesedwin1123

spp_registry_name_suffix/data/name_suffix_data.xml

@@ -6,143 +6,143 @@
         <field name="name">Jr.</field>
         <field name="code">JR</field>
         <field name="sequence">10</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">Junior - typically used for a son named after his father</field>
     </record>
 
     <record id="suffix_sr" model="spp.name.suffix">
         <field name="name">Sr.</field>
         <field name="code">SR</field>
         <field name="sequence">20</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">Senior - typically used for a father when a son has the same name</field>
     </record>
 
     <record id="suffix_jra" model="spp.name.suffix">
         <field name="name">Jra.</field>
         <field name="code">JRA</field>
         <field name="sequence">25</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">JRA</field>
     </record>
 
     <record id="suffix_i" model="spp.name.suffix">
         <field name="name">I</field>
         <field name="code">I</field>
         <field name="sequence">30</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The First</field>
     </record>
 
     <record id="suffix_ii" model="spp.name.suffix">
         <field name="name">II</field>
         <field name="code">II</field>
         <field name="sequence">40</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Second</field>
     </record>
 
     <record id="suffix_iii" model="spp.name.suffix">
         <field name="name">III</field>
         <field name="code">III</field>
         <field name="sequence">50</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Third</field>
     </record>
 
     <record id="suffix_iv" model="spp.name.suffix">
         <field name="name">IV</field>
         <field name="code">IV</field>
         <field name="sequence">60</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Fourth</field>
     </record>
 
     <record id="suffix_v" model="spp.name.suffix">
         <field name="name">V</field>
         <field name="code">V</field>
         <field name="sequence">70</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Fifth</field>
     </record>
 
     <record id="suffix_vi" model="spp.name.suffix">
         <field name="name">VI</field>
         <field name="code">VI</field>
         <field name="sequence">71</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Sixth</field>
     </record>
 
     <record id="suffix_vii" model="spp.name.suffix">
         <field name="name">VII</field>
         <field name="code">VII</field>
         <field name="sequence">72</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Seventh</field>
     </record>
 
     <record id="suffix_viii" model="spp.name.suffix">
         <field name="name">VIII</field>
         <field name="code">VIII</field>
         <field name="sequence">73</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Eighth</field>
     </record>
 
     <record id="suffix_ix" model="spp.name.suffix">
         <field name="name">IX</field>
         <field name="code">IX</field>
         <field name="sequence">74</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Ninth</field>
     </record>
 
     <record id="suffix_x" model="spp.name.suffix">
         <field name="name">X</field>
         <field name="code">X</field>
         <field name="sequence">75</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Tenth</field>
     </record>
 
     <record id="suffix_xi" model="spp.name.suffix">
         <field name="name">XI</field>
         <field name="code">XI</field>
         <field name="sequence">76</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Eleventh</field>
     </record>
 
     <record id="suffix_xii" model="spp.name.suffix">
         <field name="name">XII</field>
         <field name="code">XII</field>
         <field name="sequence">77</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Twelfth</field>
     </record>
 
     <record id="suffix_xiii" model="spp.name.suffix">
         <field name="name">XIII</field>
         <field name="code">XIII</field>
         <field name="sequence">78</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Thirteenth</field>
     </record>
 
     <record id="suffix_xiv" model="spp.name.suffix">
         <field name="name">XIV</field>
         <field name="code">XIV</field>
         <field name="sequence">79</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Fourteenth</field>
     </record>
 
     <record id="suffix_xv" model="spp.name.suffix">
         <field name="name">XV</field>
         <field name="code">XV</field>
         <field name="sequence">80</field>
-        <field name="exclusion_group">generational</field>
+        <field name="is_generational" eval="True" />
         <field name="description">The Fifteenth</field>
     </record>
 

spp_registry_name_suffix/models/name_suffix.py

@@ -30,10 +30,11 @@ class SPPNameSuffix(models.Model):
         string="Description",
         help="Additional description or usage notes for this suffix",
     )
-    exclusion_group = fields.Char(
-        string="Exclusion Group",
-        help="Suffixes in the same exclusion group cannot be used together. "
-        "For example, 'generational' for Jr., Sr., I, II, III, etc.",
+    is_generational = fields.Boolean(
+        string="Generational Suffix",
+        default=False,
+        help="Check this for generational suffixes (Jr., Sr., I, II, III, etc.). "
+        "Only one generational suffix can be used per individual.",
     )
 
     _sql_constraints = [

spp_registry_name_suffix/models/res_partner.py

@@ -15,32 +15,21 @@ class ResPartner(models.Model):
     )
 
     @api.constrains("suffix_ids")
-    def _check_suffix_exclusion_groups(self):
-        """Validate that no two suffixes from the same exclusion group are selected."""
+    def _check_generational_suffix_conflict(self):
+        """Validate that only one generational suffix is selected."""
         for record in self:
             if not record.suffix_ids:
                 continue
-            # Get suffixes that have an exclusion group
-            suffixes_with_groups = record.suffix_ids.filtered(lambda s: s.exclusion_group)
-            # Group by exclusion_group
-            groups = {}
-            for suffix in suffixes_with_groups:
-                group = suffix.exclusion_group
-                if group not in groups:
-                    groups[group] = []
-                groups[group].append(suffix.name)
-            # Check for conflicts
-            for group, suffix_names in groups.items():
-                if len(suffix_names) > 1:
-                    raise ValidationError(
-                        _(
-                            "The following suffixes cannot be used together "
-                            "as they belong to the same exclusion group '%(group)s': "
-                            "%(suffixes)s",
-                            group=group,
-                            suffixes=", ".join(suffix_names),
-                        )
+            generational_suffixes = record.suffix_ids.filtered(lambda s: s.is_generational)
+            if len(generational_suffixes) > 1:
+                suffix_names = ", ".join(generational_suffixes.mapped("name"))
+                raise ValidationError(
+                    _(
+                        "Only one generational suffix can be used at a time. "
+                        "The following are generational suffixes: %(suffixes)s",
+                        suffixes=suffix_names,
                     )
+                )
 
     @api.onchange("is_group", "family_name", "given_name", "addl_name", "suffix_ids")
     def name_change(self):

spp_registry_name_suffix/tests/test_name_suffix.py

@@ -244,30 +244,27 @@ def test_13_name_get_multiple_records(self):
         self.assertIn(self.suffix_jr.id, result_ids)
         self.assertIn(self.suffix_phd.id, result_ids)
 
-    def test_14_exclusion_group_set_on_generational_suffixes(self):
-        """Test that generational suffixes have exclusion group set."""
-        self.assertEqual(
-            self.suffix_jr.exclusion_group,
-            "generational",
-            "Jr. should have generational exclusion group",
+    def test_14_is_generational_set_on_generational_suffixes(self):
+        """Test that generational suffixes have is_generational flag set."""
+        self.assertTrue(
+            self.suffix_jr.is_generational,
+            "Jr. should be marked as generational",
         )
-        self.assertEqual(
-            self.suffix_sr.exclusion_group,
-            "generational",
-            "Sr. should have generational exclusion group",
+        self.assertTrue(
+            self.suffix_sr.is_generational,
+            "Sr. should be marked as generational",
         )
-        self.assertEqual(
-            self.suffix_iii.exclusion_group,
-            "generational",
-            "III should have generational exclusion group",
+        self.assertTrue(
+            self.suffix_iii.is_generational,
+            "III should be marked as generational",
         )
         self.assertFalse(
-            self.suffix_phd.exclusion_group,
-            "PhD should not have an exclusion group",
+            self.suffix_phd.is_generational,
+            "PhD should not be marked as generational",
         )
 
-    def test_15_exclusion_group_prevents_conflicting_suffixes(self):
-        """Test that two suffixes from same exclusion group cannot be selected."""
+    def test_15_generational_suffix_conflict_prevented(self):
+        """Test that two generational suffixes cannot be selected together."""
         individual = self.env["res.partner"].create(
             {
                 "name": "Temp",
@@ -277,14 +274,14 @@ def test_15_exclusion_group_prevents_conflicting_suffixes(self):
                 "is_group": False,
             }
         )
-        # Try to add both Jr. and Sr. (both in 'generational' group)
+        # Try to add both Jr. and Sr. (both generational)
         with self.assertRaises(ValidationError) as context:
             individual.write({"suffix_ids": [(6, 0, [self.suffix_jr.id, self.suffix_sr.id])]})
-        self.assertIn("generational", str(context.exception))
+        self.assertIn("generational", str(context.exception).lower())
 
-    def test_16_exclusion_group_allows_different_groups(self):
-        """Test that suffixes from different groups can be selected together."""
-        # Jr. (generational) + PhD (no group) should work
+    def test_16_generational_with_non_generational_allowed(self):
+        """Test that generational + non-generational suffixes can be combined."""
+        # Jr. (generational) + PhD (non-generational) should work
         individual = self.env["res.partner"].create(
             {
                 "name": "Temp",
@@ -299,7 +296,7 @@ def test_16_exclusion_group_allows_different_groups(self):
         individual.name_change()
         self.assertEqual(individual.name, "SMITH, JANE, JR., PHD")
 
-    def test_17_exclusion_group_roman_numerals_conflict(self):
+    def test_17_roman_numerals_conflict(self):
         """Test that two roman numeral suffixes cannot be selected together."""
         individual = self.env["res.partner"].create(
             {
@@ -311,11 +308,11 @@ def test_17_exclusion_group_roman_numerals_conflict(self):
             }
         )
         suffix_iv = self.env.ref("spp_registry_name_suffix.suffix_iv")
-        # Try to add both III and IV (both in 'generational' group)
+        # Try to add both III and IV (both generational)
         with self.assertRaises(ValidationError):
             individual.write({"suffix_ids": [(6, 0, [self.suffix_iii.id, suffix_iv.id])]})
 
-    def test_18_exclusion_group_jr_and_roman_numeral_conflict(self):
+    def test_18_jr_and_roman_numeral_conflict(self):
         """Test that Jr. and roman numerals cannot be selected together."""
         individual = self.env["res.partner"].create(
             {
@@ -326,6 +323,6 @@ def test_18_exclusion_group_jr_and_roman_numeral_conflict(self):
                 "is_group": False,
             }
         )
-        # Try to add Jr. and III (both in 'generational' group)
+        # Try to add Jr. and III (both generational)
         with self.assertRaises(ValidationError):
             individual.write({"suffix_ids": [(6, 0, [self.suffix_jr.id, self.suffix_iii.id])]})

spp_registry_name_suffix/views/name_suffix_views.xml

@@ -10,7 +10,7 @@
                 <field name="sequence" widget="handle" />
                 <field name="name" />
                 <field name="code" />
-                <field name="exclusion_group" optional="show" />
+                <field name="is_generational" />
                 <field name="active" />
             </tree>
         </field>
@@ -30,7 +30,7 @@
                         </group>
                         <group name="right_group">
                             <field name="sequence" />
-                            <field name="exclusion_group" />
+                            <field name="is_generational" />
                         </group>
                     </group>
                     <group name="description_group">
@@ -49,16 +49,13 @@
             <search>
                 <field name="name" />
                 <field name="code" />
-                <field name="exclusion_group" />
                 <filter name="filter_active" string="Active" domain="[('active', '=', True)]" />
                 <filter name="filter_inactive" string="Archived" domain="[('active', '=', False)]" />
-                <group expand="0" string="Group By">
-                    <filter
-                        name="groupby_exclusion"
-                        string="Exclusion Group"
-                        context="{'group_by': 'exclusion_group'}"
-                    />
-                </group>
+                <filter
+                    name="filter_generational"
+                    string="Generational"
+                    domain="[('is_generational', '=', True)]"
+                />
             </search>
         </field>
     </record>