[FIX] remove meaningless return after page reload in custom fields UI

Author: emjay0921

spp_custom_fields_ui/CHANGELOG.md

@@ -0,0 +1,11 @@
+# Changelog
+
+## 2025-11-20
+
+### 2025-11-20 10:12:34 - [FIX] remove meaningless return after page reload in custom fields UI
+- Fixed bug where return statement after window.location.reload() was unreachable
+- For existing records, reload happens immediately before return, destroying page context
+- For new records, setTimeout creates race condition where return value is meaningless
+- Added proper handling for result === false case without reload
+- Added comments explaining control flow in reload scenarios
+

spp_custom_fields_ui/static/src/js/custom_fields_ui_reload.js

@@ -31,13 +31,16 @@ patch(FormController.prototype, {
                     setTimeout(() => {
                         window.location.reload();
                     }, 100);
+                    // Don't return - page will reload soon, making return value meaningless
                 } else {
                     // For existing records, reload immediately
+                    // This destroys the page context, so no return is needed
                     window.location.reload();
                 }
+            } else {
+                // Save returned false, don't reload but propagate the result
+                return result;
             }
-
-            return result;
         } catch (error) {
             // Save failed (validation error, required fields missing, etc.)
             // Don't reload, let the user fix the errors