[REF] spp_event_*: Centralize event model registration with mixin pattern

Major refactoring to improve event type registration architecture and eliminate code duplication:

- Add is_event_model boolean field to ir.model in spp_event_data
- Create spp.event.mixin abstract model to encapsulate common event functionality
- Implement automatic event model registration via _register_hook()
- Provide reusable get_view_id() method through mixin

Changes to spp_event_data:
- Add models/ir_model.py: Extend ir.model with is_event_model flag
- Add models/event_mixin.py: New abstract mixin for all event types
- Update wizard/create_event_wizard.py: Dynamic selection now queries ir.model.is_event_model
- Update models/event_data.py: Handle get_view_id() for both mixin and non-mixin models

Changes to spp_event_demo:
- Refactor house_visit, phone_survey, school_enrolment to inherit spp.event.mixin
- Remove boilerplate _register_hook() and get_view_id() methods
- Delete redundant wizard/create_event_wizard.py (static selection_add)

Changes to spp_event_spec_loader:
- Update event_type_definition.py: Set is_event_model=True on dynamic model creation
- Update dynamic_event_model.py: Inherit spp.event.mixin, add guard to prevent mixin self-registration
- Remove boilerplate get_view_id() method

Benefits:
- DRY: Eliminates code duplication across event models
- Centralized: Single source of truth for event model registration
- Scalable: Works seamlessly with both static and dynamic event models
- Maintainable: Changes to event model behavior now in one place

Author: emjay0921

spp_event_data/models/event_mixin.py

@@ -17,8 +17,14 @@ def _register_hook(self):
         """
         Mark this model as an event model automatically.
         All models inheriting from this mixin will be registered as event types.
+        Note: The mixin itself (spp.event.mixin) is not registered.
         """
         super()._register_hook()
+
+        # Don't register the mixin itself as an event model
+        if self._name == "spp.event.mixin":
+            return
+
         ir_model = self.env["ir.model"].search([("model", "=", self._name)], limit=1)
         if ir_model and not ir_model.is_event_model:
             ir_model.sudo().write({"is_event_model": True})

spp_event_data/wizard/create_event_wizard.py

@@ -17,12 +17,18 @@ def _get_event_data_model_selection(self):
         """
         Dynamically get event types from models marked as event models.
         Returns a list of tuples (model_name, model_display_name).
+        Note: Mixins are prevented from registering via guards in their _register_hook.
         """
         # Start with default
         selection = [("default", "None")]
 
         # Query all models marked as event models
-        event_models = self.env["ir.model"].search([("is_event_model", "=", True)], order="name")
+        # Note: We don't filter by state since dynamic models are state='manual'
+        # Mixins are prevented from registering themselves via _register_hook guards
+        event_models = self.env["ir.model"].search(
+            [("is_event_model", "=", True)],
+            order="name",
+        )
 
         for event_model in event_models:
             selection.append((event_model.model, event_model.name))

spp_event_spec_loader/COMPLETE_IMPROVEMENTS_v17.0.1.0.3.md

@@ -448,10 +448,7 @@ understand, easier to extend, and a joy to work with! 🚀
 
 ---
 
-**Version**: 17.0.1.0.3
-**Date**: November 2024
-**Status**: ✅ **COMPLETE AND READY FOR TESTING**
-**Breaking Changes**: None
-**Migration Required**: No (automatic via upgrade)
+**Version**: 17.0.1.0.3 **Date**: November 2024 **Status**: ✅ **COMPLETE AND READY FOR TESTING** **Breaking
+Changes**: None **Migration Required**: No (automatic via upgrade)
 
 **Next Steps**: Upgrade modules and test! 🧪

spp_event_spec_loader/MIXIN_IMPROVEMENT.md

@@ -329,7 +329,5 @@ model.is_event_model  # Should be True
 
 ---
 
-**Version**: 17.0.1.0.3
-**Date**: November 2024
-**Status**: ✅ Implemented
-**Impact**: All event modules (data, demo, spec_loader)
+**Version**: 17.0.1.0.3 **Date**: November 2024 **Status**: ✅ Implemented **Impact**: All event modules
+(data, demo, spec_loader)

spp_event_spec_loader/REFACTORING_SUMMARY.md

@@ -143,5 +143,4 @@ See **REFACTORING_v17.0.1.0.3.md** for:
 **TL;DR**: Moved wizard logic from `spp_event_spec_loader` to `spp_event_data` base module and used a simple
 boolean flag (`is_event_model`) for registration. Much cleaner! ✨
 
-**Status**: ✅ Ready to test
-**Version**: 17.0.1.0.3
+**Status**: ✅ Ready to test **Version**: 17.0.1.0.3

spp_event_spec_loader/REFACTORING_v17.0.1.0.3.md

@@ -443,7 +443,5 @@ To:
 
 ---
 
-**Version**: 17.0.1.0.3
-**Date**: November 2024
-**Status**: ✅ Implemented and Tested
-**Breaking Changes**: None (backward compatible)
+**Version**: 17.0.1.0.3 **Date**: November 2024 **Status**: ✅ Implemented and Tested **Breaking Changes**:
+None (backward compatible)

spp_event_spec_loader/TESTING_CHECKLIST.md

@@ -268,8 +268,5 @@ Document any known issues:
 
 ---
 
-**Test Date**: ******\_\_\_******
-**Tested By**: ******\_\_\_******
-**Database**: ******\_\_\_******
-**Status**: [ ] PASS [ ] FAIL
-**Notes**:
+**Test Date**: **\*\***\_\_\_**\*\*** **Tested By**: **\*\***\_\_\_**\*\*** **Database**:
+**\*\***\_\_\_**\*\*** **Status**: [ ] PASS [ ] FAIL **Notes**:

spp_event_spec_loader/models/dynamic_event_model.py

@@ -2,7 +2,7 @@
 
 import logging
 
-from odoo import fields, models
+from odoo import api, fields, models
 
 _logger = logging.getLogger(__name__)
 
@@ -12,6 +12,7 @@ class DynamicEventModelMixin(models.AbstractModel):
     Mixin for dynamically created event models.
     Provides common functionality for all dynamic event types.
     Inherits from spp.event.mixin for standard event model behavior.
+    Note: This mixin itself is not registered as an event type.
     """
 
     _name = "spp.dynamic.event.mixin"
@@ -21,6 +22,16 @@ class DynamicEventModelMixin(models.AbstractModel):
     # Common fields that all dynamic event models should have
     name = fields.Char(string="Name", compute="_compute_name", store=True)
 
+    @api.model
+    def _register_hook(self):
+        """Override to prevent this mixin from registering itself"""
+        # Don't register the dynamic mixin itself as an event model
+        if self._name == "spp.dynamic.event.mixin":
+            return
+
+        # For actual event models, call parent which will register them
+        return super()._register_hook()
+
     def _compute_name(self):
         """Compute a default name for the event"""
         for rec in self: