From a03acf071496ee7d796d2a6eda991d6bc16bf6d4 Mon Sep 17 00:00:00 2001
From: red <redick@newlogic.com>
Date: Wed, 12 Mar 2025 18:10:27 +0800
Subject: [PATCH 1/2] [ADD] spp_hide_menus_base: added module for base hide
 menu

---
 spp_hide_menus_base/__init__.py               |  1 +
 spp_hide_menus_base/__manifest__.py           | 25 +++++++
 spp_hide_menus_base/models/__init__.py        |  1 +
 spp_hide_menus_base/models/hide_menu.py       | 40 +++++++++++
 spp_hide_menus_base/pyproject.toml            |  3 +
 .../security/ir.model.access.csv              |  2 +
 spp_hide_menus_base/security/security.xml     |  8 +++
 spp_hide_menus_base/views/hide_menu_view.xml  | 71 +++++++++++++++++++
 8 files changed, 151 insertions(+)
 create mode 100644 spp_hide_menus_base/__init__.py
 create mode 100644 spp_hide_menus_base/__manifest__.py
 create mode 100644 spp_hide_menus_base/models/__init__.py
 create mode 100644 spp_hide_menus_base/models/hide_menu.py
 create mode 100644 spp_hide_menus_base/pyproject.toml
 create mode 100644 spp_hide_menus_base/security/ir.model.access.csv
 create mode 100644 spp_hide_menus_base/security/security.xml
 create mode 100644 spp_hide_menus_base/views/hide_menu_view.xml

diff --git a/spp_hide_menus_base/__init__.py b/spp_hide_menus_base/__init__.py
new file mode 100644
index 000000000..0650744f6
--- /dev/null
+++ b/spp_hide_menus_base/__init__.py
@@ -0,0 +1 @@
+from . import models
diff --git a/spp_hide_menus_base/__manifest__.py b/spp_hide_menus_base/__manifest__.py
new file mode 100644
index 000000000..140caad99
--- /dev/null
+++ b/spp_hide_menus_base/__manifest__.py
@@ -0,0 +1,25 @@
+# Part of OpenSPP. See LICENSE file for full copyright and licensing details.
+
+
+{
+    "name": "Hide Non-OpenSPP Menus: Base",
+    "category": "OpenSPP",
+    "version": "17.0.1.3.0",
+    "sequence": 1,
+    "author": "OpenSPP.org",
+    "website": "https://github.com/OpenSPP/openspp-modules",
+    "license": "LGPL-3",
+    "maintainers": ["reichie020212"],
+    "depends": ["base"],
+    "data": [
+        "security/ir.model.access.csv",
+        "security/security.xml",
+        "views/hide_menu_view.xml",
+    ],
+    "assets": {},
+    "demo": [],
+    "images": [],
+    "application": True,
+    "installable": True,
+    "auto_install": False,
+}
diff --git a/spp_hide_menus_base/models/__init__.py b/spp_hide_menus_base/models/__init__.py
new file mode 100644
index 000000000..f9646e257
--- /dev/null
+++ b/spp_hide_menus_base/models/__init__.py
@@ -0,0 +1 @@
+from . import hide_menu
diff --git a/spp_hide_menus_base/models/hide_menu.py b/spp_hide_menus_base/models/hide_menu.py
new file mode 100644
index 000000000..172c2349d
--- /dev/null
+++ b/spp_hide_menus_base/models/hide_menu.py
@@ -0,0 +1,40 @@
+# Part of OpenSPP. See LICENSE file for full copyright and licensing details.
+
+import logging
+
+from odoo import fields, models
+
+_logger = logging.getLogger(__name__)
+
+
+class OpenSPPHideMenu(models.Model):
+    _name = "spp.hide.menu"
+    _description = "Hide Menu Configuration"
+
+    name = fields.Many2one("ir.ui.menu", required=True)
+    state = fields.Selection(
+        [("show", "Show"), ("hide", "Hidden")],
+        default="show",
+    )
+    default_groups_id = fields.Many2many("res.groups")
+
+    def hide_menu(self, menu_id=None):
+        record = self
+        if menu_id:
+            record = self.browse(menu_id)
+        for rec in record:
+            if rec.state == "show" and rec.name:
+                show_non_openspp_group = [(6, 0, [self.env.ref("spp_hide_menus_base.show_non_openspp_menu_group").id])]
+                rec.default_groups_id = rec.name.groups_id
+                rec.name.write(
+                    {
+                        "groups_id": show_non_openspp_group,
+                    }
+                )
+                rec.state = "hide"
+
+    def show_menu(self):
+        for rec in self:
+            if rec.state == "hide" and rec.name:
+                rec.name.groups_id = rec.default_groups_id
+                rec.state = "show"
diff --git a/spp_hide_menus_base/pyproject.toml b/spp_hide_menus_base/pyproject.toml
new file mode 100644
index 000000000..4231d0ccc
--- /dev/null
+++ b/spp_hide_menus_base/pyproject.toml
@@ -0,0 +1,3 @@
+[build-system]
+requires = ["whool"]
+build-backend = "whool.buildapi"
diff --git a/spp_hide_menus_base/security/ir.model.access.csv b/spp_hide_menus_base/security/ir.model.access.csv
new file mode 100644
index 000000000..b7fe00eb0
--- /dev/null
+++ b/spp_hide_menus_base/security/ir.model.access.csv
@@ -0,0 +1,2 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+spp_hide_menu_admin,Hide Menu Configuration Admin Access,spp_hide_menus_base.model_spp_hide_menu,base.group_system,1,1,1,1
diff --git a/spp_hide_menus_base/security/security.xml b/spp_hide_menus_base/security/security.xml
new file mode 100644
index 000000000..2bcaf3c1b
--- /dev/null
+++ b/spp_hide_menus_base/security/security.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+
+    <record id="show_non_openspp_menu_group" model="res.groups">
+        <field name="name">Show Non-OpenSPP Menu</field>
+    </record>
+
+</odoo>
diff --git a/spp_hide_menus_base/views/hide_menu_view.xml b/spp_hide_menus_base/views/hide_menu_view.xml
new file mode 100644
index 000000000..75b406bcf
--- /dev/null
+++ b/spp_hide_menus_base/views/hide_menu_view.xml
@@ -0,0 +1,71 @@
+<odoo>
+    <record id="view_spp_hide_menu_tree" model="ir.ui.view">
+        <field name="name">view_spp_hide_menu_tree</field>
+        <field name="model">spp.hide.menu</field>
+        <field name="priority">1</field>
+        <field name="arch" type="xml">
+            <tree editable="bottom">
+                <field name="name" />
+                <field
+                    name="state"
+                    decoration-primary="state=='show'"
+                    decoration-danger="state=='hide'"
+                    widget="badge"
+                />
+                <button
+                    name="hide_menu"
+                    type="object"
+                    icon="fa-eye-slash"
+                    title="Hide Menu"
+                    help="Hide Menu"
+                    class="btn-danger"
+                    invisible="state == 'hide'"
+                    groups="base.group_system"
+                />
+                <button
+                    name="show_menu"
+                    type="object"
+                    icon="fa-eye"
+                    title="Show Menu"
+                    help="Show Menu"
+                    class="btn-primary"
+                    invisible="state == 'show'"
+                    groups="base.group_system"
+                />
+            </tree>
+        </field>
+    </record>
+
+    <record id="action_spp_hide_menu" model="ir.actions.act_window">
+        <field name="name">Hide Menu Configuration</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="res_model">spp.hide.menu</field>
+        <field name="view_mode">tree,form</field>
+        <field name="context">{}</field>
+        <field name="domain">[]</field>
+        <field name="help" type="html">
+            <p class="o_view_nocontent_smiling_face">
+                Create a new Hide Menu Configuration!
+            </p><p>
+                Click the create button to enter the information of the Menu to be hidden.
+            </p>
+        </field>
+    </record>
+
+    <record id="action_spp_hide_menu_tree_view" model="ir.actions.act_window.view">
+        <field name="sequence" eval="1" />
+        <field name="view_mode">tree</field>
+        <field name="view_id" ref="view_spp_hide_menu_tree" />
+        <field name="act_window_id" ref="action_spp_hide_menu" />
+    </record>
+
+    <menuitem
+        id="menu_spp_hide_menu"
+        name="Hidden Menus"
+        action="action_spp_hide_menu"
+        parent="base.menu_users"
+        sequence="1000"
+        groups="base.group_no_one"
+    />
+
+</odoo>

From 4dd818e90ed44a9892236625cda38de7045cb31e Mon Sep 17 00:00:00 2001
From: red <redick@newlogic.com>
Date: Wed, 12 Mar 2025 18:11:44 +0800
Subject: [PATCH 2/2] [REF] spp_hide_menus: moved code to the base module

---
 spp_hide_menus/__init__.py                  |  2 -
 spp_hide_menus/__manifest__.py              |  4 +-
 spp_hide_menus/data/hide_menu_data.xml      |  4 --
 spp_hide_menus/i18n/spp_hide_menus.pot      |  2 +-
 spp_hide_menus/models/__init__.py           |  1 -
 spp_hide_menus/models/hide_menu.py          | 40 ------------
 spp_hide_menus/security/ir.model.access.csv |  2 -
 spp_hide_menus/views/hide_menu_view.xml     | 71 ---------------------
 8 files changed, 2 insertions(+), 124 deletions(-)
 delete mode 100644 spp_hide_menus/models/__init__.py
 delete mode 100644 spp_hide_menus/models/hide_menu.py
 delete mode 100644 spp_hide_menus/security/ir.model.access.csv
 delete mode 100644 spp_hide_menus/views/hide_menu_view.xml

diff --git a/spp_hide_menus/__init__.py b/spp_hide_menus/__init__.py
index c4ccea794..441611e10 100644
--- a/spp_hide_menus/__init__.py
+++ b/spp_hide_menus/__init__.py
@@ -1,3 +1 @@
 # Part of OpenSPP. See LICENSE file for full copyright and licensing details.
-
-from . import models
diff --git a/spp_hide_menus/__manifest__.py b/spp_hide_menus/__manifest__.py
index 0cbe91934..c745da443 100644
--- a/spp_hide_menus/__manifest__.py
+++ b/spp_hide_menus/__manifest__.py
@@ -11,11 +11,9 @@
     "license": "LGPL-3",
     "development_status": "Production/Stable",
     "maintainers": ["jeremi", "gonzalesedwin1123"],
-    "depends": ["base", "calendar", "contacts", "account", "event", "stock", "utm", "web", "g2p_registry_base"],
+    "depends": ["base", "spp_hide_menus_base", "calendar", "contacts", "account", "event", "stock", "utm", "web"],
     "data": [
-        "security/ir.model.access.csv",
         "data/hide_menu_data.xml",
-        "views/hide_menu_view.xml",
     ],
     "assets": {},
     "demo": [],
diff --git a/spp_hide_menus/data/hide_menu_data.xml b/spp_hide_menus/data/hide_menu_data.xml
index fe3ced0e2..d66e1fe9a 100644
--- a/spp_hide_menus/data/hide_menu_data.xml
+++ b/spp_hide_menus/data/hide_menu_data.xml
@@ -1,10 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <odoo>
 
-    <record id="show_non_openspp_menu_group" model="res.groups">
-        <field name="name">Show Non-OpenSPP Menu</field>
-    </record>
-
     <!-- Hide Calendar Menu -->
     <record id="hide_calendar_menu" model="spp.hide.menu">
         <field name="name" eval="ref('calendar.mail_menu_calendar')" />
diff --git a/spp_hide_menus/i18n/spp_hide_menus.pot b/spp_hide_menus/i18n/spp_hide_menus.pot
index 5b2629dc9..b7f58dc2a 100644
--- a/spp_hide_menus/i18n/spp_hide_menus.pot
+++ b/spp_hide_menus/i18n/spp_hide_menus.pot
@@ -96,7 +96,7 @@ msgid "Show Menu"
 msgstr ""
 
 #. module: spp_hide_menus
-#: model:res.groups,name:spp_hide_menus.show_non_openspp_menu_group
+#: model:res.groups,name:spp_hide_menu_base.show_non_openspp_menu_group
 msgid "Show Non-OpenSPP Menu"
 msgstr ""
 
diff --git a/spp_hide_menus/models/__init__.py b/spp_hide_menus/models/__init__.py
deleted file mode 100644
index f9646e257..000000000
--- a/spp_hide_menus/models/__init__.py
+++ /dev/null
@@ -1 +0,0 @@
-from . import hide_menu
diff --git a/spp_hide_menus/models/hide_menu.py b/spp_hide_menus/models/hide_menu.py
deleted file mode 100644
index 0fc92cb5f..000000000
--- a/spp_hide_menus/models/hide_menu.py
+++ /dev/null
@@ -1,40 +0,0 @@
-# Part of OpenSPP. See LICENSE file for full copyright and licensing details.
-
-import logging
-
-from odoo import fields, models
-
-_logger = logging.getLogger(__name__)
-
-
-class OpenSPPHideMenu(models.Model):
-    _name = "spp.hide.menu"
-    _description = "Hide Menu Configuration"
-
-    name = fields.Many2one("ir.ui.menu", required=True)
-    state = fields.Selection(
-        [("show", "Show"), ("hide", "Hidden")],
-        default="show",
-    )
-    default_groups_id = fields.Many2many("res.groups")
-
-    def hide_menu(self, menu_id=None):
-        record = self
-        if menu_id:
-            record = self.browse(menu_id)
-        for rec in record:
-            if rec.state == "show" and rec.name:
-                show_non_openspp_group = [(6, 0, [self.env.ref("spp_hide_menus.show_non_openspp_menu_group").id])]
-                rec.default_groups_id = rec.name.groups_id
-                rec.name.write(
-                    {
-                        "groups_id": show_non_openspp_group,
-                    }
-                )
-                rec.state = "hide"
-
-    def show_menu(self):
-        for rec in self:
-            if rec.state == "hide" and rec.name:
-                rec.name.groups_id = rec.default_groups_id
-                rec.state = "show"
diff --git a/spp_hide_menus/security/ir.model.access.csv b/spp_hide_menus/security/ir.model.access.csv
deleted file mode 100644
index d8931e426..000000000
--- a/spp_hide_menus/security/ir.model.access.csv
+++ /dev/null
@@ -1,2 +0,0 @@
-id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-spp_hide_menu_admin,Hide Menu Configuration Admin Access,spp_hide_menus.model_spp_hide_menu,g2p_registry_base.group_g2p_admin,1,1,1,1
diff --git a/spp_hide_menus/views/hide_menu_view.xml b/spp_hide_menus/views/hide_menu_view.xml
deleted file mode 100644
index 9b1449a92..000000000
--- a/spp_hide_menus/views/hide_menu_view.xml
+++ /dev/null
@@ -1,71 +0,0 @@
-<odoo>
-    <record id="view_spp_hide_menu_tree" model="ir.ui.view">
-        <field name="name">view_spp_hide_menu_tree</field>
-        <field name="model">spp.hide.menu</field>
-        <field name="priority">1</field>
-        <field name="arch" type="xml">
-            <tree editable="bottom">
-                <field name="name" />
-                <field
-                    name="state"
-                    decoration-primary="state=='show'"
-                    decoration-danger="state=='hide'"
-                    widget="badge"
-                />
-                <button
-                    name="hide_menu"
-                    type="object"
-                    icon="fa-eye-slash"
-                    title="Hide Menu"
-                    help="Hide Menu"
-                    class="btn-danger"
-                    invisible="state == 'hide'"
-                    groups="g2p_registry_base.group_g2p_admin"
-                />
-                <button
-                    name="show_menu"
-                    type="object"
-                    icon="fa-eye"
-                    title="Show Menu"
-                    help="Show Menu"
-                    class="btn-primary"
-                    invisible="state == 'show'"
-                    groups="g2p_registry_base.group_g2p_admin"
-                />
-            </tree>
-        </field>
-    </record>
-
-    <record id="action_spp_hide_menu" model="ir.actions.act_window">
-        <field name="name">Hide Menu Configuration</field>
-        <field name="type">ir.actions.act_window</field>
-        <field name="res_model">spp.hide.menu</field>
-        <field name="view_mode">tree,form</field>
-        <field name="context">{}</field>
-        <field name="domain">[]</field>
-        <field name="help" type="html">
-            <p class="o_view_nocontent_smiling_face">
-                Create a new Hide Menu Configuration!
-            </p><p>
-                Click the create button to enter the information of the Menu to be hidden.
-            </p>
-        </field>
-    </record>
-
-    <record id="action_spp_hide_menu_tree_view" model="ir.actions.act_window.view">
-        <field name="sequence" eval="1" />
-        <field name="view_mode">tree</field>
-        <field name="view_id" ref="view_spp_hide_menu_tree" />
-        <field name="act_window_id" ref="action_spp_hide_menu" />
-    </record>
-
-    <menuitem
-        id="menu_spp_hide_menu"
-        name="Hidden Menus"
-        action="action_spp_hide_menu"
-        parent="base.menu_users"
-        sequence="1000"
-        groups="base.group_no_one"
-    />
-
-</odoo>