Fix model selector overflow on mobile by using shortName#461
Merged
AnthonyRonning merged 3 commits intomasterfrom Mar 6, 2026
Merged
Fix model selector overflow on mobile by using shortName#461AnthonyRonning merged 3 commits intomasterfrom
AnthonyRonning merged 3 commits intomasterfrom
Conversation
On smaller mobile devices, long model display names (e.g. 'OpenAI GPT-OSS 120B') push the send button off-screen. Use the shorter shortName field (e.g. 'GPT-OSS') for the dropdown button label instead. Fixes #460 Co-Authored-By: marks <markskram@protonmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying maple with
|
| Latest commit: |
b5e2174
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5fdb55f6.maple-ca8.pages.dev |
| Branch Preview URL: | https://devin-1772757384-fix-model-s.maple-ca8.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Here is a screenshot of an iPhone 4. Possible to make it work for this @devin-ai-integration
|
Constrain the model selector button to max-w-[120px] with text truncation so it works on very small screens like iPhone 4 (320px wide). The button text will truncate with ellipsis if it exceeds the max width. Co-Authored-By: marks <markskram@protonmail.com>
Contributor
Author
|
Thanks for the iPhone 4 screenshot! I've pushed a second commit that adds:
This should keep the send button visible even on 320px-wide screens. The new Cloudflare preview build is deploying now — you can re-test once it's live. |
devin-ai-integration
bot
changed the title
This reverts commit 09bddb7.
devin-ai-integration
bot
changed the title
Contributor
|
I had devin revert the iPhone 4 stuff because it didn't make a difference and we don't even support iPhone 4. It's working great now. |
marksftw
approved these changes
Mar 6, 2026
Contributor
|
yeah that was the purpose of shortname in the first place, not sure how it got reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On smaller mobile devices (e.g. iPhone 15), long model display names like "OpenAI GPT-OSS 120B" or "DeepSeek R1 671B" in the model selector button push the send button off-screen.
getDropdownLabel()now prefersshortName(e.g. "GPT-OSS", "DeepSeek R1") overdisplayNamefor the collapsed button label. The fulldisplayNameis still shown inside the dropdown menu items.Note: the two primary models ("Quick" / "Powerful") are unaffected — they have hardcoded labels via early returns. This change only impacts models selected from the "More models" advanced view.
Fixes #460
Updates since last revision
max-w-[120px]/ CSS truncation commit per reviewer request. The fix is now purely theshortNamepreference — no layout/CSS changes.Review & Testing Checklist for Human
Notes