Let's extract method from onlyOwner modifier

[k06a]

I would like to extract onlyModifier behavior out of modifier like this:

modifier onlyOwner() {
    if (onlyOwnerMethod(msg.sender)) {
        _;
    }
}

function onlyOwnerMethod(address wallet) internal constant returns (bool) {
    require(wallet == owner);
    return true;
}

This will allow to override modifier behavior for example with Multiownable smart contract: https://github.com/bitclave/Multiownable

[federicobond]

Thanks for the suggestionn @k06a! Ownable already declares a single owner field, so I think we are better off with a separate contract (like Multiownable) for handling other use cases.

[k06a]

@federicobond I am thinking about making possible this case:

contract MultiCrowdsale is FinalizableCrowdsale, Multiownable { }

To override Ownable with Multiownable for some contracts who are already Ownable.

[federicobond]

For that use case, I suggest you set the owner of the Crowdsale to a Multisig wallet and relay transactions through it. This leaves the logic of both contracts intact and more clearly separates concerns between the two well-audited contracts.

[k06a]

@federicobond smart enough 👍

[k06a]

@federicobond found a tricky way to override Ownable by Multiownable. Take a look at MultisigMintableToken: bitclave/Multiownable#1