use configuration option instead of CLI argument

Author: schlndh

src/Config.php

@@ -65,7 +65,6 @@
  * @property string      $stdinContent    Content passed directly to PHPCS on STDIN.
  * @property string      $stdinPath       The path to use for content passed on STDIN.
  * @property bool        $trackTime       Whether or not to track sniff run time.
- * @property bool        $allowEmptyFileList Suppresses "No files were checked" error.
  *
  * @property array<string, string>      $extensions File extensions that should be checked, and what tokenizer is used.
  *                                                  E.g., array('inc' => 'PHP');
@@ -161,43 +160,42 @@ class Config
      * @var array<string, mixed>
      */
     private $settings = [
-        'files'              => null,
-        'standards'          => null,
-        'verbosity'          => null,
-        'interactive'        => null,
-        'parallel'           => null,
-        'cache'              => null,
-        'cacheFile'          => null,
-        'colors'             => null,
-        'explain'            => null,
-        'local'              => null,
-        'showSources'        => null,
-        'showProgress'       => null,
-        'quiet'              => null,
-        'annotations'        => null,
-        'tabWidth'           => null,
-        'encoding'           => null,
-        'extensions'         => null,
-        'sniffs'             => null,
-        'exclude'            => null,
-        'ignored'            => null,
-        'reportFile'         => null,
-        'generator'          => null,
-        'filter'             => null,
-        'bootstrap'          => null,
-        'reports'            => null,
-        'basepath'           => null,
-        'reportWidth'        => null,
-        'errorSeverity'      => null,
-        'warningSeverity'    => null,
-        'recordErrors'       => null,
-        'suffix'             => null,
-        'stdin'              => null,
-        'stdinContent'       => null,
-        'stdinPath'          => null,
-        'trackTime'          => null,
-        'unknown'            => null,
-        'allowEmptyFileList' => null,
+        'files'           => null,
+        'standards'       => null,
+        'verbosity'       => null,
+        'interactive'     => null,
+        'parallel'        => null,
+        'cache'           => null,
+        'cacheFile'       => null,
+        'colors'          => null,
+        'explain'         => null,
+        'local'           => null,
+        'showSources'     => null,
+        'showProgress'    => null,
+        'quiet'           => null,
+        'annotations'     => null,
+        'tabWidth'        => null,
+        'encoding'        => null,
+        'extensions'      => null,
+        'sniffs'          => null,
+        'exclude'         => null,
+        'ignored'         => null,
+        'reportFile'      => null,
+        'generator'       => null,
+        'filter'          => null,
+        'bootstrap'       => null,
+        'reports'         => null,
+        'basepath'        => null,
+        'reportWidth'     => null,
+        'errorSeverity'   => null,
+        'warningSeverity' => null,
+        'recordErrors'    => null,
+        'suffix'          => null,
+        'stdin'           => null,
+        'stdinContent'    => null,
+        'stdinPath'       => null,
+        'trackTime'       => null,
+        'unknown'         => null,
     ];
 
     /**
@@ -583,7 +581,6 @@ public function restoreDefaults()
         $this->stdinPath       = null;
         $this->trackTime       = false;
         $this->unknown         = [];
-        $this->allowEmptyFileList = false;
 
         $standard = self::getConfigData('default_standard');
         if ($standard !== null) {
@@ -831,14 +828,6 @@ public function processLongArgument(string $arg, int $pos)
                 $this->annotations = false;
                 $this->overriddenDefaults['annotations'] = true;
                 break;
-            case 'allow-empty-file-list':
-                if (isset($this->overriddenDefaults['allowEmptyFileList']) === true) {
-                    break;
-                }
-
-                $this->allowEmptyFileList = true;
-                $this->overriddenDefaults['allowEmptyFileList'] = true;
-                break;
             case 'config-set':
                 if (isset($this->cliArgs[($pos + 1)]) === false
                     || isset($this->cliArgs[($pos + 2)]) === false

src/Runner.php

@@ -351,7 +351,7 @@ private function run()
         }
 
         $numFiles = count($todo);
-        if ($numFiles === 0 && $this->config->allowEmptyFileList === false) {
+        if ($numFiles === 0 && Config::getConfigData('allow_empty_file_list') !== '1') {
             $error  = 'ERROR: No files were checked.' . PHP_EOL;
             $error .= 'All specified files were excluded or did not match filtering rules.' . PHP_EOL . PHP_EOL;
             throw new DeepExitException($error, ExitCode::PROCESS_ERROR);

src/Util/Help.php

@@ -579,7 +579,7 @@ private function getAllOptions()
 
             'config-explain' => [
                 'text' => 'Default values for a selection of options can be stored in a user-specific CodeSniffer.conf configuration file.' . "\n"
-                    . 'This applies to the following options: "default_standard", "report_format", "tab_width", "encoding", "severity", "error_severity", "warning_severity", "show_warnings", "report_width", "show_progress", "quiet", "colors", "cache", "parallel", "installed_paths", "php_version", "ignore_errors_on_exit", "ignore_warnings_on_exit", "ignore_non_auto_fixable_on_exit".',
+                    . 'This applies to the following options: "default_standard", "report_format", "tab_width", "encoding", "severity", "error_severity", "warning_severity", "show_warnings", "report_width", "show_progress", "quiet", "colors", "cache", "parallel", "installed_paths", "php_version", "ignore_errors_on_exit", "ignore_warnings_on_exit", "ignore_non_auto_fixable_on_exit", "allow_empty_file_list".',
             ],
             'config-show'    => [
                 'argument'    => '--config-show',

tests/Core/Runner/RunAllFilesExcludedErrorTest.php

@@ -90,7 +90,9 @@ public function testPhpcsAllowEmpty($sourceDir, $extraArgs)
             $this->markTestSkipped('This test needs CS mode to run');
         }
 
-        $extraArgs[] = '--allow-empty-file-list';
+        $extraArgs[] = '--runtime-set';
+        $extraArgs[] = 'allow_empty_file_list';
+        $extraArgs[] = '1';
         $this->setupTest($sourceDir, $extraArgs);
 
         $runner = new Runner();
@@ -119,7 +121,9 @@ public function testPhpcbfAllowEmpty($sourceDir, $extraArgs)
             $this->markTestSkipped('This test needs CBF mode to run');
         }
 
-        $extraArgs[] = '--allow-empty-file-list';
+        $extraArgs[] = '--runtime-set';
+        $extraArgs[] = 'allow_empty_file_list';
+        $extraArgs[] = '1';
         $this->setupTest($sourceDir, $extraArgs);
 
         $runner = new Runner();