Skip to content

noven: modify keyboard shortcut, modify event check input #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrotman-pic opened this issue May 28, 2021 · 2 comments
Open

noven: modify keyboard shortcut, modify event check input #464

hrotman-pic opened this issue May 28, 2021 · 2 comments

Comments

@hrotman-pic
Copy link
Collaborator

hrotman-pic commented May 28, 2021

Request 1, remove duplicate shortcut:
noven currently has Ctrl+C as a shortcut for both 'Check input' and 'Configure/Change Parameters', which prevents the shortcut from being used for either function. Could the keyboard shortcuts for these be changed so they are not duplicates? Edited to clarify: this may only affect Linux systems; the ambiguous shortcut may not exist on Macs.

Request 2: modify event check input:
Currently, noven will fail a receiver (array) csv that has a station ID not compatible with SEG-Y revision 1, but will not fail an event csv that has an event ID not compatible. I would like to ask if noven's checks can be modified so that:

  1. when a user selects 'check input' for an event csv in noven, noven will check that all event IDs are less than 32767 and fail the event csv if that is not true for any event IDs (am requesting the check used on receiver csv for station IDs be used on event csv for event IDs),
    OR
  2. when a user selects 'check input' for either event or receiver, an event or station ID between 32767 and 65535 will result in a warning that the PH5 will not be compatible with SEG-Y revision 1 (similar to what ph5_validate does now), but allow the csv to be saved as a kef, and that an event or station ID more than 65535 will result in an error and prevent the event or receiver csv from being saved as a kef.

I prefer the first, because it results in a PH5 fully compatible with SEG-Y rev1 (unless the values are changed later), is consistent with the existing check for a receiver csv, and we can still use ph5_validate to see incompatibilities with existing PH5s.

@hrotman-pic
Copy link
Collaborator Author

Related to #465 per today's meeting, I'm adding to this issue to request noven to fail any receiver csv with a DAS serial number field containing the string E+ to prevent the same problem from occurring in the future.

@hrotman-pic
Copy link
Collaborator Author

If implemented, event check input should error if the shot_ID is greater than 2,147,483,647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant