custom configuration based on ARduino uno not building due to settings

[bschwand]

Hello,

I am trying to define a custom configuration using the arduino uno (nano actually) and it fails to compile

Compiling .pio\build\AVR-UNO\src\src\modules\Examples\extended_task.c.o
uCNC\src\modules\Examples\extended_setting.c: In function 'extend_settings_load':
uCNC\src\modules\Examples\extended_setting.c:35:40: warning: passing argument 2 of 'settings_load' from incompatible pointer type [-Wincompatible-pointer-types]
  settings_load(dummy_settings_address, &dummy_setting, sizeof(dummy_setting));
                                        ^
In file included from uCNC\src\modules\Examples\../../cnc.h:143:0,
                 from uCNC\src\modules\Examples\extended_setting.c:11:
uCNC\src\modules\Examples\../../interface/grbl_settings.h:195:10: note: expected 'uint8_t * {aka unsigned char *}' but argument is of type 'uint32_t * {aka long unsigned int *}'
  uint8_t settings_load(uint16_t address, uint8_t *__ptr, uint16_t size);
       ^~~~~~~~~~~~~
uCNC\src\modules\Examples\extended_setting.c: In function 'extend_settings_erase':
uCNC\src\modules\Examples\extended_setting.c:77:2: error: unknown type name 'settings_args_t'; did you mean 'setting_args_t'?
  settings_args_t *set = (settings_args_t *)args;
  ^~~~~~~~~~~~~~~
  setting_args_t
uCNC\src\modules\Examples\extended_task.c: In function 'mycustom_task_module_init':
uCNC\src\modules\Examples\extended_task.c:59:2: warning: #warning "Main loop extensions are not enabled. Your module will not work." [-Wcpp]
 #warning "Main loop extensions are not enabled. Your module will not work."
  ^~~~~~~
uCNC\src\modules\Examples\extended_setting.c:77:26: error: 'settings_args_t' undeclared (first use in this function); did you mean 'setting_args_t'?

.....

I checked settings are not disabled, is there another place to enable them ?
I used the online configuration editor, cloned uCNC from master, just added M17 support and single axis homing.

Is there some mandatory tweak to do to the configuration regarding settings support ?

thanks for any help.

ucnc_build (1).json

[Paciente8159]

I tested your configuration file and it build (almost) without issues. The thing is that the UNO is near the flash limit size.
In this case with your options the code occupies 120% of the flash available.

Make sure you are using a clean code source, place all configuration files inside the folder and select the correct environment on PlatformIO.

[bschwand]

thought I'd try with v1.12.2 instead of master and I get a different compilation error

CREATE_EVENT_LISTENER(proto_cnc_settings, extend_protocol_send_cnc_settings); ^~~~~~~~~~~~~~~~~~~~~ In file included from uCNC\src\modules\Examples\../../modules/shift_register.h:29:0, from uCNC\src\modules\Examples\../../cnc_hal_config_helper.h:57, from uCNC\src\modules\Examples\../../cnc.h:135, from uCNC\src\modules\Examples\extended_setting.c:11: uCNC\src\modules\Examples\extended_setting.c: In function 'dummy_init': uCNC\src\modules\Examples\extended_setting.c:108:21: error: unknown type name 'settings_load_delegate_event_t' ADD_EVENT_LISTENER(settings_load, extend_settings_load); ^ uCNC\src\modules\Examples\../../modules/../module.h:72:10: note: in definition of macro 'ADD_EVENT_LISTENER' extern name##_delegate_event_t name##_delegate_##handler; \ ^~~~ uCNC\src\modules\Examples\extended_setting.c:108:21: error: 'settings_load_event' undeclared (first use in this function); did you mean 'settings_load'? ADD_EVENT_LISTENER(settings_load, extend_settings_load); ^ uCNC\src\modules\Examples\../../modules/../module.h:73:7: note: in definition of macro 'ADD_EVENT_LISTENER' if (name##_event == NULL) \ ^~~~ uCNC\src\modules\Examples\extended_setting.c:108:21: error: unknown type name 'settings_load_delegate_event_t'; did you mean 'settings_extended_load_delegate_event_t'? ADD_EVENT_LISTENER(settings_load, extend_settings_load);

still about the settings though

[bschwand]

even uncommenting DISABLE_SETTINGS_MODULE in cnc_config.h does not help, still compile error about settings_args_t

[bschwand]

settings_args_t does not exist anywhere in the source
$ fgrep -rnH settings_args_t *
uCNC/src/modules/Examples/extended_setting.c:77: settings_args_t *set = (settings_args_t *)args;
uCNC/src/README.md:56:| settings_extended_load | NULL | ENABLE_SETTINGS_MODULES | Fires when the base settings ($) are loaded from memory. Arg is a pointer to a settings_args_t struct |
uCNC/src/README.md:57:| settings_extended_save | NULL | ENABLE_SETTINGS_MODULES | Fires when the base settings ($) are saved into memory. Arg is a pointer to a settings_args_t struct |

very confused

and if I correct for the actual existing setting_args_t, I get a bunch of undefined members error

uCNC\src\modules\Examples\extended_setting.c: In function 'extend_settings_erase':
uCNC\src\modules\Examples\extended_setting.c:79:9: error: 'setting_args_t {aka struct setting_args_}' has no member named 'address'
if (set->address == SETTINGS_ADDRESS_OFFSET)

is there a discrepancy between modules sources and the main uCNC repo ?

which BTW bring me to the question: why isn't the module repo used as a git submodule, so on any given uCNC version we know the correct modules version that works with it ?

[Paciente8159]

uCNC-modules is not a git submodule of uCNC.
The platformio.ini that is generated in the web builder tells a special script which modules are used and only those are extracted to the modules dir.

You seemed to have included all the uCNC modules inside modules dir (including the Examples modules (that seems to contains that typo)

[Paciente8159]

I guess you downloaded all uCNC modules and extracted them...If you did..that is the issue. Only download the master branch and the zip with the config files...you only need the modules zip if you are going to add them manually (for example if using arduino ide)

[bschwand]

I think the module examples are stale...
also after removing the Examples, it seems to go over all the modules and build them. Throwing errors in the process because some pieces are not enabled. Are we supposed to only have the sources in modules/ for any module that is required in the build ? seems a bit weird, I added the archive provided by the config generator

[bschwand]

sorry I did not see your replies
yes that is what happened

seems to me like a very weird way to build, never seen such a thing. Add and remove folders for each modules as needed ? I mean to me it seems very wacky, it means your build tree changes depending on what you want to build. That is what a build system is there for...

It would be much better if all the sources are present but selectively compiled, either by makefile definitions or with #ifdef in the .c/.h files.

Don't you think ? what is the motivation for using presence/absence of code as part of the build system selection ?

[Paciente8159]

Because some modules may contain multiple files and might be generic or architecture specific. Also some modules depend on other external libraries (displays, sd cards, etc..) Depending on the tool chain or IDE you are using it can be build up and generate a bunch of errors that might not even be related to any thing you configured. Although this seems a bit weird this works a add-per-need basis.
The risk of getting things broken because of a bad module that you don't even use is highly reduced.

Yes it does make things a bit complicated in one way but less messy in another.

I can try to make some experiences in the near future about that.