From f260ec7d8c6766c05ee3ebeefaad63669876bde7 Mon Sep 17 00:00:00 2001 From: "padarn.wilson" Date: Sat, 25 Jun 2022 16:13:04 +0800 Subject: [PATCH 1/3] make benchmark arguments more flexible --- benchmark/loader/neighbor_loader.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/benchmark/loader/neighbor_loader.py b/benchmark/loader/neighbor_loader.py index cd8f7ed0186b..f1d6e1185fde 100644 --- a/benchmark/loader/neighbor_loader.py +++ b/benchmark/loader/neighbor_loader.py @@ -11,6 +11,7 @@ def run(args: argparse.ArgumentParser) -> None: + print(args.hetero_neighbor_sizes) for dataset_name in args.datasets: print(f"Dataset: {dataset_name}") root = osp.join(args.root, dataset_name) @@ -83,10 +84,14 @@ def run(args: argparse.ArgumentParser) -> None: add('--device', default='cpu') add('--datasets', nargs="+", default=['arxiv', 'products', 'mag']) add('--root', default='../../data') - add('--batch-sizes', default=[8192, 4096, 2048, 1024, 512]) - add('--eval-batch-sizes', default=[16384, 8192, 4096, 2048, 1024, 512]) - add('--homo-neighbor_sizes', default=[[10, 5], [15, 10, 5], [20, 15, 10]]) - add('--hetero-neighbor_sizes', default=[[5], [10], [10, 5]], type=int) + add('--batch-sizes', default=[8192, 4096, 2048, 1024, 512], type=int, + nargs='+') + add('--eval-batch-sizes', default=[16384, 8192, 4096, 2048, 1024, 512], + type=int, nargs='+') + add('--homo-neighbor_sizes', default=[[10, 5], [15, 10, 5], [20, 15, 10]], + type=int, nargs='+') + add('--hetero-neighbor_sizes', default=[[5], [10], [10, 5]], type=int, + nargs='+') add('--num-workers', default=0) add('--runs', default=3) From 4f0df800249921c4baefcace6698926ea8ceac0d Mon Sep 17 00:00:00 2001 From: "padarn.wilson" Date: Sat, 25 Jun 2022 16:15:26 +0800 Subject: [PATCH 2/3] make benchmark arguments more flexible --- benchmark/loader/neighbor_loader.py | 1 - 1 file changed, 1 deletion(-) diff --git a/benchmark/loader/neighbor_loader.py b/benchmark/loader/neighbor_loader.py index f1d6e1185fde..7460b743a0c7 100644 --- a/benchmark/loader/neighbor_loader.py +++ b/benchmark/loader/neighbor_loader.py @@ -11,7 +11,6 @@ def run(args: argparse.ArgumentParser) -> None: - print(args.hetero_neighbor_sizes) for dataset_name in args.datasets: print(f"Dataset: {dataset_name}") root = osp.join(args.root, dataset_name) From e99b07124f1b37717fa7de3235d37415e928bf34 Mon Sep 17 00:00:00 2001 From: "Szarmach, Michal" Date: Mon, 4 Jul 2022 15:06:41 +0200 Subject: [PATCH 3/3] adding support for handy change list of list params usage example: python neighbor_loader.py --hetero-neighbor_sizes [[1],[1,2]] --homo-neighbor_sizes [[3],[1,2]] constrains: you cannot use the nargs with that(?) --- benchmark/loader/neighbor_loader.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/benchmark/loader/neighbor_loader.py b/benchmark/loader/neighbor_loader.py index 7460b743a0c7..17e58d985ebb 100644 --- a/benchmark/loader/neighbor_loader.py +++ b/benchmark/loader/neighbor_loader.py @@ -3,6 +3,7 @@ from timeit import default_timer import tqdm +import ast from ogb.nodeproppred import PygNodePropPredDataset import torch_geometric.transforms as T @@ -88,9 +89,9 @@ def run(args: argparse.ArgumentParser) -> None: add('--eval-batch-sizes', default=[16384, 8192, 4096, 2048, 1024, 512], type=int, nargs='+') add('--homo-neighbor_sizes', default=[[10, 5], [15, 10, 5], [20, 15, 10]], - type=int, nargs='+') - add('--hetero-neighbor_sizes', default=[[5], [10], [10, 5]], type=int, - nargs='+') + type=ast.literal_eval) + add('--hetero-neighbor_sizes', default=[[5], [10], [10, 5]], + type=ast.literal_eval) add('--num-workers', default=0) add('--runs', default=3)