diff --git a/yolov3/dataset/download_voc.py b/yolov3/dataset/download_voc.py index 95068d7..8687f7a 100644 --- a/yolov3/dataset/download_voc.py +++ b/yolov3/dataset/download_voc.py @@ -34,7 +34,26 @@ def download_decompress_file(data_dir, url, md5): tar_file = _download(url, data_dir, md5) logger.info("Decompressing {}".format(tar_file)) with tarfile.open(tar_file) as tf: - tf.extractall(path=data_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, path=data_dir) os.remove(tar_file)