[P3] Code Quality: Improve TypeScript strict mode compliance

[Pamacea]

Priority

P3 - Low Priority

Category

Code Quality

Description

The codebase has TypeScript strict mode enabled but has many any types and type assertions that bypass type safety.

Issues Found

1. Excessive use of any

// Bad - Bypasses type checking
function processData(data: any) {
  return data.map((item: any) => item.value);
}

// Good - Proper types
interface DataItem {
  value: string;
}

function processData(data: DataItem[]) {
  return data.map(item => item.value);
}

2. Type assertions without validation

// Bad - Unsafe assertion
const value = data as Character;

// Good - Validation
const isCharacter = (data: unknown): data is Character => {
  return typeof data === 'object' && 
         'name' in data && 
         'gameWorldId' in data;
};

3. Missing return types

// Bad - Implicit return type
export function getConfig() {
  return { apiKey: '...' };
}

// Good - Explicit return type
interface Config {
  apiKey: string;
}

export function getConfig(): Config {
  return { apiKey: '...' };
}

tsconfig.json Improvements

{
  "compilerOptions": {
    "strict": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictBindCallApply": true,
    "strictPropertyInitialization": true,
    "noImplicitThis": true,
    "alwaysStrict": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": true,
    "noUncheckedIndexedAccess": true,
    "noImplicitOverride": true,
    "noPropertyAccessFromIndexSignature": true
  }
}

Implementation Plan

1. Enable stricter compiler options
2. Fix any types incrementally
3. Add proper type guards
4. Use Zod schemas for runtime validation + types
5. Add explicit return types

Success Criteria

• Zero any types (except for specific, documented exceptions)
• All public functions have explicit return types
• No type assertions without validation
• tsconfig.json has all strict options enabled

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com