enveloped response handling

Author: kossak

paperspace/exceptions.py

@@ -22,5 +22,13 @@ class PresignedUrlConnectionError(ApplicationError):
     pass
 
 
+class PresignedUrlMalformedResponseError(ApplicationError):
+    pass
+
+
+class PresignedUrlError(ApplicationError):
+    pass
+
+
 class S3UploadFailedError(ApplicationError):
     pass

paperspace/workspace.py

@@ -9,7 +9,8 @@
 from paperspace import logger as default_logger
 
 from paperspace.exceptions import S3UploadFailedError, PresignedUrlUnreachableError, \
-    PresignedUrlAccessDeniedError, PresignedUrlConnectionError, ProjectAccessDeniedError
+    PresignedUrlAccessDeniedError, PresignedUrlConnectionError, ProjectAccessDeniedError, \
+    PresignedUrlMalformedResponseError, PresignedUrlError
 
 
 class S3WorkspaceHandler:
@@ -143,4 +144,13 @@ def _get_upload_data(self, file_name, project_handle):
             raise PresignedUrlUnreachableError
         if not response.ok:
             raise PresignedUrlConnectionError(response.reason)
-        return response.json()
+
+        response_content = response.json()
+        try:
+            response_message = response_content['message']
+            response_data = response_content['data']
+        except KeyError:
+            raise PresignedUrlMalformedResponseError(response_data)
+        if response_message != 'success':
+            raise PresignedUrlError(response)
+        return response_data