fix: remove under specified update command PS-10086

Author: bbatha

paperspace/cli/deployments.py

@@ -110,47 +110,6 @@ def get_deployments_list(api_key=None, **filters):
     command.execute(filters=filters)
 
 
-@deployments.command("update", help="Update deployment properties")
-@click.option(
-    "--id",
-    "id_",
-    required=True,
-    help="Deployment ID",
-)
-@click.option(
-    "--modelId",
-    "modelId",
-    help="ID of a trained model",
-)
-@click.option(
-    "--name",
-    "name",
-    help="Human-friendly name for new model deployment",
-)
-@click.option(
-    "--machineType",
-    "machineType",
-    help="Type of machine for new deployment",
-)
-@click.option(
-    "--imageUrl",
-    "imageUrl",
-    help="Docker image for model serving",
-)
-@click.option(
-    "--instanceCount",
-    "instanceCount",
-    type=int,
-    help="Number of machine instances",
-)
-@api_key_option
-def update_deployment_model(id_, api_key, **kwargs):
-    del_if_value_is_none(kwargs)
-    deployments_api = client.API(config.CONFIG_HOST, api_key=api_key)
-    command = deployments_commands.UpdateDeploymentCommand(api=deployments_api)
-    command.execute(id_, kwargs)
-
-
 @deployments.command("start", help="Start deployment")
 @click.option(
     "--id",

paperspace/commands/deployments.py

@@ -65,20 +65,6 @@ def _get_table_data(self, deployments):
         return data
 
 
-class UpdateDeploymentCommand(_DeploymentCommandBase):
-    def execute(self, deployment_id, kwargs):
-        if not kwargs:
-            self.logger.log("No parameters to update were given. Use --help for more information.")
-            return
-
-        json_ = {"id": deployment_id,
-                 "upd": kwargs}
-        response = self.api.post("/deployments/updateDeployment/", json=json_)
-        self._log_message(response,
-                          "Deployment model updated.",
-                          "Unknown error occurred.")
-
-
 class StartDeploymentCommand(_DeploymentCommandBase):
     def execute(self, deployment_id):
         json_ = {"id": deployment_id,

tests/functional/test_deployments.py

@@ -205,76 +205,6 @@ def test_should_print_proper_message_when_wrong_api_key_was_used(self, get_patch
         assert result.output == "Invalid API token\n"
 
 
-class TestDeploymentsUpdate(object):
-    URL = "https://api.paperspace.io/deployments/updateDeployment/"
-    COMMAND = [
-        "deployments", "update",
-        "--id", "some_id",
-        "--name", "new_name",
-    ]
-    BASIC_OPTIONS_REQUEST_JSON = {"upd": {"name": u"new_name"}, "id": u"some_id"}
-
-    COMMAND_WITH_API_KEY = [
-        "deployments", "update",
-        "--id", "some_id",
-        "--name", "new_name",
-        "--apiKey", "some_key"
-    ]
-    EXPECTED_HEADERS_WITH_CHANGED_API_KEY = paperspace.client.default_headers.copy()
-    EXPECTED_HEADERS_WITH_CHANGED_API_KEY["X-API-Key"] = "some_key"
-
-    RESPONSE_JSON_200 = {"upd": {"name": u"asd"}, "id": u"dennaw0wzbvvg3"}
-    EXPECTED_STDOUT = "Deployment model updated.\n"
-
-    RESPONSE_JSON_400 = {"error": {"name": "Error", "status": 400, "message": "Unable to access deployment"}}
-    EXPECTED_STDOUT_WITH_WRONG_ID = "Unable to access deployment\n"
-
-    @mock.patch("paperspace.cli.deployments.deployments_commands.client.requests.post")
-    def test_should_send_proper_data_and_print_message_when_update_deployment(self, post_patched):
-        post_patched.return_value = MockResponse(self.RESPONSE_JSON_200, 200, "fake content")
-
-        runner = CliRunner()
-        result = runner.invoke(cli.cli, self.COMMAND)
-
-        post_patched.assert_called_once_with(self.URL,
-                                             headers=EXPECTED_HEADERS,
-                                             json=self.BASIC_OPTIONS_REQUEST_JSON,
-                                             params=None,
-                                             files=None)
-        assert result.output == self.EXPECTED_STDOUT
-        assert result.exit_code == 0
-
-    @mock.patch("paperspace.cli.deployments.deployments_commands.client.requests.post")
-    def test_should_send_proper_data_with_custom_api_key_when_api_key_parameter_was_provided(self, post_patched):
-        post_patched.return_value = MockResponse(self.RESPONSE_JSON_200, 200, "fake content")
-
-        runner = CliRunner()
-        result = runner.invoke(cli.cli, self.COMMAND_WITH_API_KEY)
-
-        post_patched.assert_called_once_with(self.URL,
-                                             headers=self.EXPECTED_HEADERS_WITH_CHANGED_API_KEY,
-                                             json=self.BASIC_OPTIONS_REQUEST_JSON,
-                                             params=None,
-                                             files=None)
-        assert result.output == self.EXPECTED_STDOUT
-        assert result.exit_code == 0
-
-    @mock.patch("paperspace.cli.deployments.deployments_commands.client.requests.post")
-    def test_should_send_proper_data_and_print_message_when_update_deployment_used_with_wrong_id(self, post_patched):
-        post_patched.return_value = MockResponse(self.RESPONSE_JSON_400, 400, "fake content")
-
-        runner = CliRunner()
-        result = runner.invoke(cli.cli, self.COMMAND)
-
-        post_patched.assert_called_once_with(self.URL,
-                                             headers=EXPECTED_HEADERS,
-                                             json=self.BASIC_OPTIONS_REQUEST_JSON,
-                                             params=None,
-                                             files=None)
-        assert result.output == self.EXPECTED_STDOUT_WITH_WRONG_ID
-        assert result.exit_code == 0
-
-
 class TestStartDeployment(object):
     URL = "https://api.paperspace.io/deployments/updateDeployment/"
     COMMAND = ["deployments", "start",