Skip to content

Commit d10d25a

Browse files
committed
Disable tutorial_nemo_3D for now
1 parent 3f2d25b commit d10d25a

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,9 @@ jobs:
7777
environment-file: environment.yml
7878
- name: Integration test
7979
# TODO v4: Re-enable `tutorial_periodic_boundaries`, `tutorial_timevaryingdepthdimensions` and `tutorial_croco_3D` notebooks
80+
# TODO v4: Re-enable `tutorial_nemo_3D` notebook once 3D grids are implemented (https://github.com/OceanParcels/Parcels/pull/1936#issuecomment-2717666705)
8081
run: |
81-
coverage run -m pytest -v -s --nbval-lax -k "not documentation and not tutorial_periodic_boundaries and not tutorial_timevaryingdepthdimensions and not tutorial_croco_3D" --html="${{ matrix.os }}_${{ matrix.python-version }}_integration_test_report.html" --self-contained-html docs/examples
82+
coverage run -m pytest -v -s --nbval-lax -k "not documentation and not tutorial_periodic_boundaries and not tutorial_timevaryingdepthdimensions and not tutorial_croco_3D and not tutorial_nemo_3D" --html="${{ matrix.os }}_${{ matrix.python-version }}_integration_test_report.html" --self-contained-html docs/examples
8283
coverage xml
8384
- name: Codecov
8485
uses: codecov/codecov-action@v5.3.1

parcels/fieldfilebuffer.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,10 @@ def latlon(self):
8484

8585
@property
8686
def depth(self):
87+
self.indices["depth"] = range(self.zdim)
8788
if "depth" in self.dimensions:
88-
depth = self.dataset[self.dimensions["depth"]]
89-
self.indices["depth"] = range(self.zdim)
90-
return depth
91-
else:
92-
self.indices["depth"] = [0]
93-
return np.zeros(1)
89+
return self.dataset[self.dimensions["depth"]]
90+
return np.zeros(1)
9491

9592
@property
9693
def data_full_zdim(self):

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ platforms = ["win-64", "linux-64", "osx-64", "osx-arm64"]
4646

4747
[tool.pixi.tasks]
4848
tests = "pytest"
49-
tests-notebooks = "pytest -v -s --nbval-lax -k 'not documentation and not tutorial_periodic_boundaries and not tutorial_timevaryingdepthdimensions and not tutorial_croco_3D'" # TODO v4: Re-enable `tutorial_periodic_boundaries`, `tutorial_timevaryingdepthdimensions`, and `tutorial_croco_3D` notebooks
49+
tests-notebooks = "pytest -v -s --nbval-lax -k 'not documentation and not tutorial_periodic_boundaries and not tutorial_timevaryingdepthdimensions and not tutorial_croco_3D and not tutorial_nemo_3D'" # TODO v4: Re-enable `tutorial_periodic_boundaries`, `tutorial_timevaryingdepthdimensions`, `tutorial_croco_3D`, `tutorial_nemo_3D` notebooks
5050
coverage = "coverage run -m pytest && coverage html"
5151
typing = "mypy parcels"
5252
pre-commit = "pre-commit run --all-files"

0 commit comments

Comments
 (0)