From bc5eea37dabb20546a1ef5adac537a61c373711e Mon Sep 17 00:00:00 2001
From: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Date: Mon, 10 Mar 2025 10:41:42 +0100
Subject: [PATCH] Replace upload of mypy to codecov with artifact upload

---
 .github/workflows/ci.yml | 16 +++++++---------
 environment.yml          |  1 +
 pyproject.toml           |  1 +
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index ae96082f22..75e1a995ba 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -97,6 +97,7 @@ jobs:
     needs:
       - unit-test
       - integration-test
+      - typechecking
     steps:
       - name: Merge Artifacts
         uses: actions/upload-artifact/merge@v4
@@ -116,13 +117,10 @@ jobs:
       - run: conda install lxml # dep for report generation
       - name: Typechecking
         run: |
-          mypy --install-types --non-interactive parcels --cobertura-xml-report mypy_report
-      - name: Upload mypy coverage to Codecov
-        uses: codecov/codecov-action@v5.3.1
-        if: ${{ always() }} # Upload even on error of mypy
-        env:
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+          mypy --install-types --non-interactive parcels --html-report mypy-report
+      - name: Upload test results
+        if: ${{ always() }} # Upload even on mypy error
+        uses: actions/upload-artifact@v4
         with:
-          file: mypy_report/cobertura.xml
-          flags: mypy
-          fail_ci_if_error: false
+          name: Mypy report
+          path: mypy-report
diff --git a/environment.yml b/environment.yml
index 54686feb05..82f505f8e2 100644
--- a/environment.yml
+++ b/environment.yml
@@ -30,6 +30,7 @@ dependencies: #! Keep in sync with [tool.pixi.dependencies] in pyproject.toml
 
   # Typing
   - mypy
+  - lxml # in CI
   - types-tqdm
   - types-psutil
 
diff --git a/pyproject.toml b/pyproject.toml
index 4c39befae8..272cad6a36 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -85,6 +85,7 @@ coverage = "*"
 
 # Typing
 mypy = "*"
+lxml = "*" # in CI
 types-tqdm = "*"
 types-psutil = "*"