From 7adcd9475a767adaf9079d8d3c3f36c0ea38593b Mon Sep 17 00:00:00 2001 From: j-atkins <106238905+j-atkins@users.noreply.github.com> Date: Tue, 17 Feb 2026 14:18:27 +0100 Subject: [PATCH 1/3] increase random noise bounds --- src/virtualship/utils.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/virtualship/utils.py b/src/virtualship/utils.py index 549c998b..7ef77734 100644 --- a/src/virtualship/utils.py +++ b/src/virtualship/utils.py @@ -15,8 +15,8 @@ import numpy as np import pyproj import xarray as xr -from parcels import FieldSet +from parcels import FieldSet from virtualship.errors import CopernicusCatalogueError if TYPE_CHECKING: @@ -569,7 +569,7 @@ def _find_files_in_timerange( return [fname for _, fname in files_with_dates] -def _random_noise(scale: float = 0.01, limit: float = 0.03) -> float: +def _random_noise(scale: float = 0.05, limit: float = 0.1) -> float: """Generate a small random noise value for drifter seeding locations.""" value = np.random.normal(loc=0.0, scale=scale) return np.clip(value, -limit, limit) # ensure noise is within limits From 48b8880a0ca3533391419d778a5972bd446acf81 Mon Sep 17 00:00:00 2001 From: j-atkins <106238905+j-atkins@users.noreply.github.com> Date: Tue, 17 Feb 2026 14:46:53 +0100 Subject: [PATCH 2/3] move test drifters away from domain edge --- tests/instruments/test_drifter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/instruments/test_drifter.py b/tests/instruments/test_drifter.py index 51f78883..8fd29549 100644 --- a/tests/instruments/test_drifter.py +++ b/tests/instruments/test_drifter.py @@ -39,7 +39,7 @@ def test_simulate_drifters(tmpdir) -> None: drifters = [ Drifter( spacetime=Spacetime( - location=Location(latitude=0.05, longitude=0.05), + location=Location(latitude=0.5, longitude=0.5), time=base_time + datetime.timedelta(days=0), ), depth=0.0, From 71da155bd2a4f760ed6e71d15ea00f39bf22b700 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 17 Feb 2026 13:47:44 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/virtualship/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/virtualship/utils.py b/src/virtualship/utils.py index 7ef77734..cef83501 100644 --- a/src/virtualship/utils.py +++ b/src/virtualship/utils.py @@ -15,8 +15,8 @@ import numpy as np import pyproj import xarray as xr - from parcels import FieldSet + from virtualship.errors import CopernicusCatalogueError if TYPE_CHECKING: