Remove unneeded setReturnValue

TheGlitch76 · web-flow · commit c396a6cf0bd1 · 2020-07-21T18:27:41.000-05:00
diff --git a/patchwork-loot/src/main/java/net/patchworkmc/mixin/loot/MixinLootPoolSerializer.java b/patchwork-loot/src/main/java/net/patchworkmc/mixin/loot/MixinLootPoolSerializer.java
@@ -44,9 +44,6 @@ public class MixinLootPoolSerializer {
 	private void addNameToConstructor(JsonElement elem, Type ty, JsonDeserializationContext ctx, CallbackInfoReturnable<LootPool> cir, JsonObject obj) {
 		LootPool ret = cir.getReturnValue();
 		((PatchworkLootPool) ret).patchwork$setName(LootHooks.readPoolName(obj));
-
-		// is this necessary?
-		cir.setReturnValue(ret);
 	}
 
 	@Redirect(method = "serialize", at = @At(value = "NEW", args = "class=com/google/gson/JsonObject"))

Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,6 @@ public class MixinLootPoolSerializer {`
`44`	`44`	`private void addNameToConstructor(JsonElement elem, Type ty, JsonDeserializationContext ctx, CallbackInfoReturnable<LootPool> cir, JsonObject obj) {`
`45`	`45`	`LootPool ret = cir.getReturnValue();`
`46`	`46`	`((PatchworkLootPool) ret).patchwork$setName(LootHooks.readPoolName(obj));`
`47`		`-`
`48`		`- // is this necessary?`
`49`		`- cir.setReturnValue(ret);`
`50`	`47`	`}`
`51`	`48`
`52`	`49`	`@Redirect(method = "serialize", at = @At(value = "NEW", args = "class=com/google/gson/JsonObject"))`