Implement public Biome getRiver() (#35)

* implement public Biome getRiver()

* import order

* import order 2

* license

* failed biome check

* fix code

* fix concurrentmodificationexception

* use an iterator like coderbot suggested

* yeet

* fuck

* update gitignorer

* coderbot's changes

* @OverRide

Author: valoeghese

.gitignore

@@ -8,6 +8,7 @@
 .settings
 .project
 *.launch
+.recommenders
 
 # Intellij/Idea
 .factorypath

patchwork-biomes/src/main/java/com/patchworkmc/impl/biomes/PatchworkBiomes.java

@@ -0,0 +1,94 @@
+/*
+ * Minecraft Forge, Patchwork Project
+ * Copyright (c) 2016-2020, 2019-2020
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation version 2.1
+ * of the License.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+package com.patchworkmc.impl.biomes;
+
+import java.util.Iterator;
+import java.util.Set;
+
+import com.google.common.collect.Sets;
+
+import net.minecraft.util.registry.Registry;
+import net.minecraft.world.biome.Biome;
+import net.minecraft.world.biome.Biomes;
+
+import net.fabricmc.api.ModInitializer;
+import net.fabricmc.fabric.api.biomes.v1.OverworldBiomes;
+import net.fabricmc.fabric.api.event.registry.RegistryEntryAddedCallback;
+import net.fabricmc.fabric.api.event.server.ServerStartCallback;
+
+public final class PatchworkBiomes implements ModInitializer {
+	private static Set<Biome> failedBiomes = Sets.newHashSet();
+
+	@Override
+	public void onInitialize() {
+		Registry.BIOME.forEach(PatchworkBiomes::addRivers);
+		RegistryEntryAddedCallback.event(Registry.BIOME).register((rawid, id, biome) -> {
+			addRivers(biome);
+			updateFailedBiomes();
+		});
+		ServerStartCallback.EVENT.register(server -> updateFailedBiomes());
+	}
+
+	private static void addRivers(Biome biome) {
+		Biome river = ((RiverSupplier) biome).getRiver();
+
+		if (river == null) {
+			failedBiomes.add(biome);
+			return;
+		}
+
+		setRiverIfNotDefault(biome, river);
+	}
+
+	private static void updateFailedBiomes() {
+		if (!failedBiomes.isEmpty()) {
+			Iterator<Biome> iterator = failedBiomes.iterator();
+
+			while (iterator.hasNext()) {
+				Biome biome = iterator.next();
+				Biome river = ((RiverSupplier) biome).getRiver();
+
+				if (river == null) {
+					continue;
+				}
+
+				iterator.remove();
+
+				setRiverIfNotDefault(biome, river);
+			}
+		}
+	}
+
+	private static void setRiverIfNotDefault(Biome biome, Biome river) {
+		if (river != getDefaultRiver(biome)) {
+			OverworldBiomes.setRiverBiome(biome, river);
+		}
+	}
+
+	public static Biome getDefaultRiver(Biome biome) {
+		if (biome == Biomes.SNOWY_TUNDRA) {
+			return Biomes.FROZEN_RIVER;
+		} else if (biome == Biomes.MUSHROOM_FIELDS || biome == Biomes.MUSHROOM_FIELD_SHORE) {
+			return Biomes.MUSHROOM_FIELD_SHORE;
+		}
+
+		return Biomes.RIVER;
+	}
+}

patchwork-biomes/src/main/java/com/patchworkmc/impl/biomes/RiverSupplier.java

@@ -0,0 +1,26 @@
+/*
+ * Minecraft Forge, Patchwork Project
+ * Copyright (c) 2016-2020, 2019-2020
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation version 2.1
+ * of the License.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+package com.patchworkmc.impl.biomes;
+
+import net.minecraft.world.biome.Biome;
+
+public interface RiverSupplier {
+	Biome getRiver();
+}

patchwork-biomes/src/main/java/com/patchworkmc/mixin/biomes/MixinBiome.java

@@ -0,0 +1,36 @@
+/*
+ * Minecraft Forge, Patchwork Project
+ * Copyright (c) 2016-2020, 2019-2020
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation version 2.1
+ * of the License.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+package com.patchworkmc.mixin.biomes;
+
+import org.spongepowered.asm.mixin.Mixin;
+
+import net.minecraft.world.biome.Biome;
+
+import com.patchworkmc.impl.biomes.RiverSupplier;
+import com.patchworkmc.impl.biomes.PatchworkBiomes;
+
+@Mixin(Biome.class)
+public class MixinBiome implements RiverSupplier {
+	@Override
+	public Biome getRiver() {
+		Biome self = (Biome) (Object) this;
+		return PatchworkBiomes.getDefaultRiver(self);
+	}
+}

patchwork-biomes/src/main/resources/fabric.mod.json

@@ -17,6 +17,14 @@
     "patchwork-fml": "*"
   },
   "description": "Implementation of the Forge Biomes API.",
+  "entrypoints": {
+    "main": [
+      "com.patchworkmc.impl.biomes.PatchworkBiomes"
+    ]
+  },
+  "mixins": [
+    "patchwork-biomes.mixins.json"
+  ],
   "custom": {
     "modmenu:api": true,
     "modmenu:parent": "patchwork"

patchwork-biomes/src/main/resources/patchwork-biomes.mixins.json

@@ -0,0 +1,11 @@
+{
+  "required": true,
+  "package": "com.patchworkmc.mixin.biomes",
+  "compatibilityLevel": "JAVA_8",
+  "mixins": [
+    "MixinBiome"
+  ],
+  "injectors": {
+    "defaultRequire": 1
+  }
+}