Skip to content

Commit 7290f78

Browse files
committed
Merge master into release branch
2 parents bdb5cef + 5ccc2cc commit 7290f78

File tree

6 files changed

+58
-10
lines changed

6 files changed

+58
-10
lines changed

RELEASE.md

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,36 @@ First, update the version number in bower.json, package.json, VERSION.txt and ad
2727
git tag 2.0.0
2828
git push && git push --tags
2929

30-
## update VERSION.txt to the next logical version number and append '-dev' to it.
30+
## checkout master, update VERSION.txt to the next logical version number and append '-dev' to it.
31+
32+
## Create the release in github
33+
34+
- Go to https://github.com/Patternslib/Patterns/releases/
35+
- Click the new tag
36+
- Click "Edit tag"
37+
- Add a Title, e.g. "2.0.14 - Aug 15, 2016"
38+
- Copy the corresponding changelog part into the body field
39+
- Finally click "Publish release"
40+
41+
## Release to npmjs.org
42+
43+
Run:
44+
45+
- npm login
46+
- npm version <update_type>
47+
where update_type is patch, minor or major. See https://docs.npmjs.com/getting-started/publishing-npm-packages.
48+
- npm publish
49+
50+
51+
## Now contact support@syslab.com and request an update of the patternslib.com site as well.
52+
53+
This is done as follows:
54+
55+
- Log into patternslib.syslab.com
56+
57+
sudo -iu patternslib
58+
cd Patterns-site
59+
cd patternslib
60+
git pull
61+
make clean && make bundle
62+

VERSION.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
// Patternslib 2.1.0
1+
// Patternslib 2.1.1-dev
22

changes.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## 2.1.1 - Aug. 28, 2017
4+
5+
- pat-modal: Only add a panel-header to the first panel-content element within pat-modal, not everyone. Otherwise this may collide with pat-collapsible which also creates a panel-content class further down the DOM (pilz)
6+
- pat-modal: Fix an issue where chrome is so quick that a modal is closed before the actual injection call can be sent.
7+
38
## 2.1.0 - Jun. 26, 2017
49

510
- pat-gallery: Also include the node with the ``pat-gallery`` class trigger for initializing the gallery.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "patternslib",
3-
"version": "2.1.0",
3+
"version": "2.1.1",
44
"title": "Markup patterns to drive behaviour.",
55
"description": "Patternslib is a JavaScript library that enables designers to build rich interactive prototypes without the need for writing any Javascript. All events are triggered by classes and other attributes in the HTML, without abusing the HTML as a programming language. Accessibility, SEO and well structured HTML are core values of Patterns.",
66
"author": {

src/pat/collapsible/collapsible.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ define([
5858
return;
5959
}
6060

61-
this.$panel = $el.find(".panel-content");
61+
this.$panel = $el.children(".panel-content");
6262
if (this.$panel.length === 0) {
6363
if ($content.length) {
6464
this.$panel = $content

src/pat/modal/modal.js

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ define([
6464
} else {
6565
this.$el.append("<div class='panel-content' />");
6666
}
67-
$(".panel-content", this.$el).before($header);
67+
this.$el.children(".panel-content").before($header);
6868
this.$el.children(this.options.panelHeaderContent).prependTo($header);
6969

7070
// Restore focus in case the active element was a child of $el and
@@ -147,12 +147,23 @@ define([
147147
utils.redraw(this.$el.find(".panel-body"));
148148
}
149149
},
150-
151150
destroy: function() {
152-
$(document).off(".pat-modal");
153-
this.$el.remove();
154-
$('body').removeClass("modal-active");
155-
}
151+
var $el = this.$el;
152+
if ($el.find('form').hasClass('pat-inject') ) {
153+
// if pat-inject in modal form, listen to patterns-inject-triggered and destroy first
154+
// once that has been triggered
155+
$('body').on( "patterns-inject-triggered", function() {
156+
$(document).off(".pat-modal");
157+
$el.remove();
158+
$('body').removeClass("modal-active");
159+
});
160+
} else {
161+
// if working without injection, destroy right away.
162+
$(document).off(".pat-modal");
163+
$el.remove();
164+
$('body').removeClass("modal-active");
165+
}
166+
}
156167
});
157168
});
158169

0 commit comments

Comments
 (0)