Skip to content

Query replication mirrors UI: change upsert key columns input to textfield #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Query replication mirrors UI: change upsert key columns input to textfield #3749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32cca00
change upsert key to textfield
Amogh-Bharadwaj Nov 27, 2025
fe98273
cleanup
Amogh-Bharadwaj Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ui/app/mirrors/create/qrep/qrep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ export default function QRepConfigForm({
const [sourceTables, setSourceTables] = useState<
{ value: string; label: string }[]
>([]);
const [allColumns, setAllColumns] = useState<
{ value: string; label: string }[]
>([]);
const [watermarkColumns, setWatermarkColumns] = useState<
{ value: string; label: string }[]
>([]);
Expand Down Expand Up @@ -122,12 +119,6 @@ export default function QRepConfigForm({
const types = allowedTypesForWatermarkColumn.get(sourceType);
return !types || types.has(col.type);
});
setAllColumns(
cols.map((col) => ({
value: col.name,
label: `${col.name} (${col.type})`,
}))
);
setWatermarkColumns(
filteredCols.map((col) => ({
value: col.name,
Expand Down Expand Up @@ -218,7 +209,6 @@ export default function QRepConfigForm({
/>
) : setting.label === 'Upsert Key Columns' ? (
<UpsertColsDisplay
columns={allColumns}
loading={loading}
setter={setter}
setting={setting}
Expand Down
107 changes: 52 additions & 55 deletions ui/app/mirrors/create/qrep/upsertcols.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,93 @@
'use client';
import { Dispatch, SetStateAction, useEffect, useState } from 'react';
import ReactSelect from 'react-select';

import SelectTheme from '@/app/styles/select';
import {
QRepConfig,
QRepWriteMode,
QRepWriteType,
} from '@/grpc_generated/flow';
import { Badge } from '@/lib/Badge';
import { Icon } from '@/lib/Icon';
import { MirrorSetting } from '../helpers/common';

interface UpsertColsProps {
columns: { value: string; label: string }[];
loading: boolean;
setter: Dispatch<SetStateAction<QRepConfig>>;
setting: MirrorSetting;
}

export default function UpsertColsDisplay({
columns,
loading,
setter,
setting,
}: UpsertColsProps) {
const [uniqueColumnsSet, setUniqueColumnsSet] = useState<Set<string>>(
new Set<string>()
);
const [upsertColumnsText, setUpsertColumnsText] = useState<string>('');

const handleTextChange = (value: string) => {
setUpsertColumnsText(value);

// Parse comma-separated values and trim whitespace
const columnsArray = value
.split(',')
.map((col) => col.trim())
.filter((col) => col.length > 0);

const handleUniqueColumns = (
col: string,
setting: MirrorSetting,
action: 'add' | 'remove'
) => {
if (action === 'add') setUniqueColumnsSet((prev) => new Set(prev).add(col));
else if (action === 'remove') {
setUniqueColumnsSet((prev) => {
const newSet = new Set(prev);
newSet.delete(col);
return newSet;
});
}
const uniqueColsArr = Array.from(uniqueColumnsSet);
setting.stateHandler(uniqueColsArr, setter);
setting.stateHandler(columnsArray, setter);
};

useEffect(() => {
const uniqueColsArr = Array.from(uniqueColumnsSet);
// Parse comma-separated values and update the config
const columnsArray = upsertColumnsText
Copy link
Member

@serprex serprex Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can memo this just to not have to repeat the expression so much

.split(',')
.map((col) => col.trim())
.filter((col) => col.length > 0);

setter((curr) => {
let defaultMode: QRepWriteMode = {
writeType: QRepWriteType.QREP_WRITE_MODE_APPEND,
upsertKeyColumns: [],
};
let currWriteMode = (curr as QRepConfig).writeMode || defaultMode;
currWriteMode.upsertKeyColumns = uniqueColsArr as string[];
currWriteMode.upsertKeyColumns = columnsArray;
return {
...curr,
writeMode: currWriteMode,
};
});
}, [uniqueColumnsSet, setter]);
}, [upsertColumnsText, setter]);

return (
<>
<ReactSelect
menuPlacement='top'
placeholder={'Select unique columns'}
onChange={(val, action) => {
val && handleUniqueColumns(val.value, setting, 'add');
<div style={{ marginTop: '1rem' }}>
<input
type='text'
placeholder='Enter column names separated by commas (e.g., id, email, created_at)'
value={upsertColumnsText}
onChange={(e) => handleTextChange(e.target.value)}
disabled={loading}
style={{
width: '100%',
padding: '8px 12px',
border: '1px solid #ccc',
borderRadius: '4px',
fontSize: '14px',
backgroundColor: loading ? '#f5f5f5' : 'white',
}}
isLoading={loading}
options={columns}
theme={SelectTheme}
/>
<div
style={{ display: 'flex', marginTop: '0.5rem', alignItems: 'center' }}
>
{Array.from(uniqueColumnsSet).map((col: string) => {
return (
<Badge key={col} variant='normal' type='default'>
{col}
<button
className='IconButton'
onClick={() => handleUniqueColumns(col, setting, 'remove')}
aria-label='remove col'
>
<Icon name='cancel' />
</button>
</Badge>
);
})}
</div>
</>
{upsertColumnsText && (
<div
style={{
marginTop: '8px',
fontSize: '12px',
color: '#666',
fontStyle: 'italic',
}}
>
Columns:{' '}
{upsertColumnsText
.split(',')
.map((col) => col.trim())
.filter((col) => col.length > 0)
.join(', ')}
</div>
)}
</div>
);
}
Loading