Skip to content

babs check-setup ignores path_in_babs config #325

@asmacdo

Description

@asmacdo

Summary

babs check-setup hardcodes inputs/data path but babs init and babs submit respects path_in_babs. When using custom paths like sourcedata/raw, check-setup fails with FileNotFoundError.

To Reproduce

  1. Use config with path_in_babs: sourcedata/raw
  2. Run babs init (succeeds)
  3. Run babs check-setup
    FileNotFoundError: [Errno 2] No such file or directory: '.../analysis/inputs/data'
    

Root Cause

check_setup.py:86 hardcodes the path:

temp_list = get_immediate_subdirectories(op.join(self.analysis_path, 'inputs/data'))

But babs init places data at path_in_babs (e.g., analysis/sourcedata/raw/).

Suggested Fix

Use self.input_datasets[i].babs_project_analysis_path which already has the correct path from config. The loop at line 94 does this correctly - only line 86 has the bug.

Workaround

Skip babs check-setup and go directly to babs submit. Or just put the data in inputs/data.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues noting problems and PRs fixing those problems.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions