Exploring GenericFactory + BeaconProxy Integration in Diamond Architecture

[JMSBPP]

Found this pattern for deploying custom instances, which is essentially a BeaconProxy factory that reads more intuitively and was implemented by Euler Labs.

As the name suggests, GenericFactory seems like a valuable component for facets, incorporating BeaconProxy with Diamonds.
This would work by adding a GenericFactoryFacet and LibGenericFactory (I’ll attach the interface here for reference) and implementing the library for MetaProxyDeployer, as shown below.

interface IGenericFactory{
    function createProxy(address desiredImplementation, bool upgradeable, bytes memory trailingData) external;
    function setImplementation(address newImplementation) external;
    function setUpgradeAdmin(address newUpgradeAdmin) external;
    function getProxyConfig(address proxy) external view returns (ProxyConfig memory config);
    function isProxy(address proxy) external view returns (bool);
    function getProxyListLength() external view returns (uint256);
    function getProxyListSlice(uint256 start, uint256 end) external view returns (address[] memory list);
}

NOTE: Replacing modifiers could involve integrating the AccessControl facet library for the admin only restriction, as well as a library for reentrancy locks

library LibMetaProxyDeployer{
    error MetaProxyDeployerDeploymentFailed();

    // Meta proxy bytecode from EIP-3488 https://eips.ethereum.org/EIPS/eip-3448
    bytes constant BYTECODE_HEAD = hex"600b380380600b3d393df3363d3d373d3d3d3d60368038038091363936013d73";
    bytes constant BYTECODE_TAIL = hex"5af43d3d93803e603457fd5bf3";



    function deployMetaProxy(address targetContract, bytes memory metadata) internal returns (address addr){
        bytes memory code = abi.encodePacked(BYTECODE_HEAD, targetContract, BYTECODE_TAIL, metadata);

        assembly ("memory-safe") {
            addr := create(0, add(code, 32), mload(code))
        }

        if (addr == address(0)) revert MetaProxyDeployerDeploymentFailed();

    }
}

NOTE: BeaconProxy does not need a facet as it is always deployed at runtime

[mudgen]

Yes, a beacon for diamonds is useful.

[JMSBPP]

Thinking of starting to work this out in an issue — would the file structure look something like this? Let me know if you feel the approach and timing are appropriate as well:

src
└── beacon/
    ├── LibMetaProxyDeployer.sol
    ├── GenericFactoryFacet.sol
    ├── LibGenericFactory.sol
    └── BeaconProxy.sol

[mudgen]

I'd be interested in looking at the code if you want to write it. It would help me understand better how this could work. But this may be too early because I am currently working out deployment, but then again it might help me with what I am working on. Just know if you implement this now it might not be incorporated now. But in any case it may be useful, and in any case, it is appreciated.

[JMSBPP]

Elaborating on this — or perhaps as a separate discussion — I noticed that CreateX could be very beneficial as a CreateXMod.

thinking of something along the lines of src/create/CreateXMod.sol

Let me know if you think this add-on would be valuable. If so, I’d be happy to start working on it.