Commit 1bf4f3b
committed
Remove "no warnings 'deprecated';" where no longer needed
These 3 unit tests (which run during t/lib/croak.t):
ok 98 - goto into expression
ok 99 - dump with computed label
ok 100 - when outside given
... no longer need "no warnings 'deprecated';" because they no longer
generate 'deprecated'-class warnings.
Inside pp_ctl.c we have a 'deprecated'-class warning at line 3655, which
falls within function PP(pp_goto). Let's take the 3 unit tests above in
turn.
"goto into expression"
The exception which generates "Can't "goto" into a binary or list
expression" occurs at +3234 pp_ctl.c, inside function S_check_op_type.
This function is called at +3646 pp_ctl.c and at +3680 pp_ctl.c, both of
which are inside function PP(pp_goto). Experimentation indicates that
the invocation at +3646 pp_ctl.c. is the triggering invocation. Hence
control passes to S_check_op_type before the deprecate_fatal warning at
+3655 can be reached.
"dump with computed label"
The exception which generates "Can't find label" occurs at +3635
pp_ctl.c -- 20 lines before the 'deprecated'-class warning.
"when outside given"
The exception which generates "Can't "when" outside a topicalizer"
occurs at +6398 pp_ctl.c, inside function PP(pp_leavewhen). It appears
that in older perls "No warnings 'deprecated';" was needed here because
of the (now apparently abandoned) deprecation of given/when.1 parent e861a6e commit 1bf4f3b
1 file changed
+3
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | 32 | | |
34 | 33 | | |
35 | | - | |
36 | 34 | | |
37 | 35 | | |
38 | 36 | | |
39 | | - | |
| 37 | + | |
40 | 38 | | |
41 | 39 | | |
42 | | - | |
| 40 | + | |
43 | 41 | | |
44 | 42 | | |
45 | 43 | | |
| |||
0 commit comments