fix(cli): make --custom-app-id work correctly in deploy command#154
Merged
fix(cli): make --custom-app-id work correctly in deploy command#154
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
The --custom-app-id option was defined but never added to the provision payload. This fix: - Adds app_id to the provision payload when --custom-app-id is specified - Adds --nonce option for PHALA KMS (required with --custom-app-id) - For ETHEREUM/BASE KMS, --custom-app-id works without --nonce - Adds validation for nonce to ensure it's a valid number - Adds validation and appropriate error messages - Adds comprehensive test coverage for all combinations
Leechael
force-pushed
the
fix/cli-custom-app-id
branch
from
906c2ab to
ba64170
Compare
h4x3rotab
previously approved these changes
Jan 23, 2026
Collaborator
Author
|
!release cli patch |
Contributor
|
🚀 @Leechael release command accepted: Target branch: |
Contributor
|
🎉 Release completed:
📦 Package Info
📄 Files included |
pacoyang
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--custom-app-idoption not being added to the provision payload--nonceoption for deterministic app_id generation (required for PHALA KMS)--custom-app-idworks without--nonceTest plan
bun test src/commands/deploy/handler.test.ts)phala deploy -c docker-compose.yml --custom-app-id <id> --kms ethereum --private-key <key> --rpc-url <url>phala deploy -c docker-compose.yml --custom-app-id <id> --nonce <nonce> --kms phala