Search field name and aliases when using the search bar

[kamathprasad9]

Description

Steps to reproduce:

• Create a local field, say "abc"
• Once created, rename it to "def"
• Try to create/search a field again with the old name, in this case "abc"

Problem probably lies in the checkFieldName method of the DataHelper

Expected behavior

No response

Field Book version

6.2.1

[bellerbrock]

Hey Prasad, I agree this is confusing but as far as I understand it's the expected functionality. The rename function updates the field alias / display name rather than the original name. That's why the original name is still found by the checkFieldName method.

I think the idea is so that at least for BrAPI fields the original name that exists on the server is not lost or duplicated. But maybe rename should affect the original name too if the field is not from BrAPI? Or the UI should be modified to make the purpose and values of both more clear. What do you think?

[kamathprasad9]

Ahh, I see.

I think there are multiple routes that we can take for this, like you mentioned @bellerbrock.

But if the expectation is for the current behavior to stay the same, at the very least, we should:

1. give the user a better descriptive message instead of just "Field name already in use". AND
2. alter the searching logic to include both field_alias and the original field name as well

On a different perspective for preserving the original field names always for brapi fields, we could allow having ONLY unique field aliases, which might lead to non-unique original field names. Basically, looking at the example I mentioned previously, allow a second field called "abc" to be created even though another field has "def" as the alias but "abc" as its original name. (Ensuring unique names for fields on the UI, but not in the db)