Why is signaly of the calibration marker used as scale value?

[JulianKlug]

Thank you for this great work!

I was wondering why the y component of the signal from the calibration marker is used to scale both X and Y component of the leads. If I read your code correctly, np.min(signaly) of the marker will be used to scale X and np.max(signaly) will be used to scale Y. Although I see the point in scaling the y component Y of the leads by Y dimension of the marker, I don't understand why the X component of the leads should be scaled by the Y component of the marker.

Would you mind detailing your reasoning for this?

IntroECG/1-Waveform Extraction/ecg_pdf_to_dataframe.py

Line 150 in b728633

scale_vals.append([np.min(signaly), np.max(signaly)])

[PierreElias]

Hi Julian, To be honest I’m not certain if this is an error or not. We almost never use this pdf conversion script as all our work is based on extracting raw waveform. If you are able to explore I welcome your clarification if this is indeed causing incorrect scaling and a pull request submission to fix it. Best, Pierre From: Julian Klug ***@***.***> Date: Tuesday, September 13, 2022 at 1:41 AM To: PierreElias/IntroECG ***@***.***> Cc: Subscribed ***@***.***> Subject: [PierreElias/IntroECG] Why is signaly of the calibration marker used as scale value? (Issue #4) Thank you for this great work! I was wondering why the y component of the signal from the calibration marker is used to scale both X and Y component of the leads. If I read your code correctly, np.min(signaly) of the marker will be used to scale X and np.max(signaly) will be used to scale Y. Although I see the point in scaling the y component Y of the leads by Y dimension of the marker, I don't understand why the X component of the leads should be scaled by the Y component of the marker. Would you mind detailing your reasoning for this? https://github.com/PierreElias/IntroECG/blob/b728633c49ef0ec3745c1ed4ffbb3e5ccec0719f/1-Waveform%20Extraction/ecg_pdf_to_dataframe.py#L150 — Reply to this email directly, view it on GitHub<#4>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACTCEYV24CJVVIDIKP3M543V6AHZJANCNFSM6AAAAAAQLCTQDY>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[JulianKlug]

Thank you for the input. I will try to look into this when I have a moment.