From 287579cb0c73beddf9dd1944f217b33e055408c7 Mon Sep 17 00:00:00 2001 From: Wojciech Grzeszczak Date: Mon, 23 Mar 2026 12:37:20 +0000 Subject: [PATCH 1/6] Hide translation utils error --- .../platformos-check-common/src/checks/translation-utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/platformos-check-common/src/checks/translation-utils.ts b/packages/platformos-check-common/src/checks/translation-utils.ts index bed4c2c..ace8813 100644 --- a/packages/platformos-check-common/src/checks/translation-utils.ts +++ b/packages/platformos-check-common/src/checks/translation-utils.ts @@ -19,7 +19,7 @@ export async function discoverModules( } } } catch (error) { - console.error(`[translation-utils] Failed to read module directory ${dirUri}:`, error); + console.debug(`[translation-utils] Module directory ${dirUri} not detected, skipping.`); } } return modules; From 083992f4480a231689acc84bd8eb86f5c9023a7f Mon Sep 17 00:00:00 2001 From: Wojciech Grzeszczak Date: Tue, 24 Mar 2026 08:08:30 +0000 Subject: [PATCH 2/6] Refactored discoverModules --- .../src/checks/translation-utils.ts | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/packages/platformos-check-common/src/checks/translation-utils.ts b/packages/platformos-check-common/src/checks/translation-utils.ts index ace8813..2b22dac 100644 --- a/packages/platformos-check-common/src/checks/translation-utils.ts +++ b/packages/platformos-check-common/src/checks/translation-utils.ts @@ -1,4 +1,4 @@ -import { FileType, TranslationProvider } from '@platformos/platformos-common'; +import { AbstractFileSystem, FileType, TranslationProvider } from '@platformos/platformos-common'; import { flattenTranslationKeys } from '../utils/levenshtein'; /** @@ -6,27 +6,26 @@ import { flattenTranslationKeys } from '../utils/levenshtein'; * Returns a deduplicated set of module names. */ export async function discoverModules( - fs: { readDirectory(uri: string): Promise<[string, FileType][]> }, + fs: AbstractFileSystem, ...moduleDirUris: string[] ): Promise> { const modules = new Set(); for (const dirUri of moduleDirUris) { - try { - const entries = await fs.readDirectory(dirUri); - for (const [entryUri, entryType] of entries) { - if (entryType === FileType.Directory) { - modules.add(entryUri.split('/').pop()!); - } + const stat = await fs.stat(dirUri).catch(() => undefined); + if (!stat || stat.type !== FileType.Directory) continue; + + const entries = await fs.readDirectory(dirUri); + for (const [entryUri, entryType] of entries) { + if (entryType === FileType.Directory) { + modules.add(entryUri.split('/').pop()!); } - } catch (error) { - console.debug(`[translation-utils] Module directory ${dirUri} not detected, skipping.`); } } return modules; } export interface TranslationContext { - fs: { readDirectory(uri: string): Promise<[string, FileType][]> }; + fs: AbstractFileSystem; toUri(relativePath: string): string; getTranslationsForBase(uri: string, locale: string): Promise>; } From 25206bae0de7b72f35b781626a15364a6eb7d647 Mon Sep 17 00:00:00 2001 From: Wojciech Grzeszczak Date: Tue, 24 Mar 2026 08:37:10 +0000 Subject: [PATCH 3/6] Fix test --- packages/liquid-html-parser/src/grammar.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/liquid-html-parser/src/grammar.ts b/packages/liquid-html-parser/src/grammar.ts index f4ba69d..15bae07 100644 --- a/packages/liquid-html-parser/src/grammar.ts +++ b/packages/liquid-html-parser/src/grammar.ts @@ -1,6 +1,11 @@ import { grammars, Grammar } from 'ohm-js'; -export const liquidHtmlGrammars = grammars(require('../grammar/liquid-html.ohm.js')); +const grammarSource: string = (() => { + const raw = require('../grammar/liquid-html.ohm.js'); + return typeof raw === 'string' ? raw : raw.default; +})(); + +export const liquidHtmlGrammars = grammars(grammarSource); export const TextNodeGrammar = liquidHtmlGrammars['Helpers']; export const LiquidDocGrammar = liquidHtmlGrammars['LiquidDoc']; From 8d2df27c7918da2317e3bd7194835702009826ff Mon Sep 17 00:00:00 2001 From: Wojciech Grzeszczak Date: Tue, 24 Mar 2026 08:54:56 +0000 Subject: [PATCH 4/6] Debug log --- packages/liquid-html-parser/src/grammar.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/liquid-html-parser/src/grammar.ts b/packages/liquid-html-parser/src/grammar.ts index 15bae07..fad9a24 100644 --- a/packages/liquid-html-parser/src/grammar.ts +++ b/packages/liquid-html-parser/src/grammar.ts @@ -2,6 +2,15 @@ import { grammars, Grammar } from 'ohm-js'; const grammarSource: string = (() => { const raw = require('../grammar/liquid-html.ohm.js'); + console.error('[grammar debug] typeof raw:', typeof raw); + console.error('[grammar debug] raw constructor:', raw?.constructor?.name); + if (typeof raw === 'object' && raw !== null) { + console.error('[grammar debug] raw keys:', Object.keys(raw).slice(0, 10)); + console.error('[grammar debug] typeof raw.default:', typeof raw.default); + if (typeof raw.default === 'object' && raw.default !== null) { + console.error('[grammar debug] raw.default keys:', Object.keys(raw.default).slice(0, 10)); + } + } return typeof raw === 'string' ? raw : raw.default; })(); From aedf41376894ca633d82620f2f05e3ff9d7b3a20 Mon Sep 17 00:00:00 2001 From: Wojciech Grzeszczak Date: Tue, 24 Mar 2026 09:02:42 +0000 Subject: [PATCH 5/6] Remove debug logs --- packages/liquid-html-parser/src/grammar.ts | 16 +--------------- .../prettier-plugin-liquid/vitest.config.mjs | 3 +++ vitest.config.mjs | 3 +++ 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a/packages/liquid-html-parser/src/grammar.ts b/packages/liquid-html-parser/src/grammar.ts index fad9a24..f4ba69d 100644 --- a/packages/liquid-html-parser/src/grammar.ts +++ b/packages/liquid-html-parser/src/grammar.ts @@ -1,20 +1,6 @@ import { grammars, Grammar } from 'ohm-js'; -const grammarSource: string = (() => { - const raw = require('../grammar/liquid-html.ohm.js'); - console.error('[grammar debug] typeof raw:', typeof raw); - console.error('[grammar debug] raw constructor:', raw?.constructor?.name); - if (typeof raw === 'object' && raw !== null) { - console.error('[grammar debug] raw keys:', Object.keys(raw).slice(0, 10)); - console.error('[grammar debug] typeof raw.default:', typeof raw.default); - if (typeof raw.default === 'object' && raw.default !== null) { - console.error('[grammar debug] raw.default keys:', Object.keys(raw.default).slice(0, 10)); - } - } - return typeof raw === 'string' ? raw : raw.default; -})(); - -export const liquidHtmlGrammars = grammars(grammarSource); +export const liquidHtmlGrammars = grammars(require('../grammar/liquid-html.ohm.js')); export const TextNodeGrammar = liquidHtmlGrammars['Helpers']; export const LiquidDocGrammar = liquidHtmlGrammars['LiquidDoc']; diff --git a/packages/prettier-plugin-liquid/vitest.config.mjs b/packages/prettier-plugin-liquid/vitest.config.mjs index 2dab585..6392c08 100644 --- a/packages/prettier-plugin-liquid/vitest.config.mjs +++ b/packages/prettier-plugin-liquid/vitest.config.mjs @@ -4,6 +4,9 @@ import { configDefaults } from 'vitest/config'; export default defineConfig({ test: { + deps: { + interopDefault: true, + }, exclude: [...configDefaults.exclude], pool: 'forks', poolOptions: { diff --git a/vitest.config.mjs b/vitest.config.mjs index 33783fa..32e1dde 100644 --- a/vitest.config.mjs +++ b/vitest.config.mjs @@ -10,6 +10,9 @@ const ciExclude = ['./packages/prettier-plugin-liquid']; export default defineConfig({ test: { + deps: { + interopDefault: true, + }, exclude: CI ? [...configDefaults.exclude, '**/dist/**', ...ciExclude] : [...configDefaults.exclude, '**/dist/**'], From d5c247b785d1bbb8b2e3c54f07a8c9b627f1881e Mon Sep 17 00:00:00 2001 From: Wojciech Grzeszczak Date: Tue, 24 Mar 2026 09:17:18 +0000 Subject: [PATCH 6/6] Clean unneeded config changes --- packages/prettier-plugin-liquid/vitest.config.mjs | 3 --- vitest.config.mjs | 3 --- 2 files changed, 6 deletions(-) diff --git a/packages/prettier-plugin-liquid/vitest.config.mjs b/packages/prettier-plugin-liquid/vitest.config.mjs index 6392c08..2dab585 100644 --- a/packages/prettier-plugin-liquid/vitest.config.mjs +++ b/packages/prettier-plugin-liquid/vitest.config.mjs @@ -4,9 +4,6 @@ import { configDefaults } from 'vitest/config'; export default defineConfig({ test: { - deps: { - interopDefault: true, - }, exclude: [...configDefaults.exclude], pool: 'forks', poolOptions: { diff --git a/vitest.config.mjs b/vitest.config.mjs index 32e1dde..33783fa 100644 --- a/vitest.config.mjs +++ b/vitest.config.mjs @@ -10,9 +10,6 @@ const ciExclude = ['./packages/prettier-plugin-liquid']; export default defineConfig({ test: { - deps: { - interopDefault: true, - }, exclude: CI ? [...configDefaults.exclude, '**/dist/**', ...ciExclude] : [...configDefaults.exclude, '**/dist/**'],