logs --session filter silently ignored: all log lines shown regardless of session

[nightmare0329]

Bug Report

Version: cortex v0.0.7
Command: cortex logs --session <session-id>

Description

The --session flag for cortex logs is advertised in the help text as "Show logs from a specific session", but it has absolutely no effect — all log lines are shown regardless of the session filter.

Steps to Reproduce

Create a log file with entries from two different sessions:

[2024-01-01 10:00:00] session-abc INFO: Message from session-abc
[2024-01-01 10:01:00] session-xyz INFO: Message from session-xyz
[2024-01-01 10:02:00] session-abc DEBUG: Another from session-abc

Filter by one session:

$ cortex logs --session session-abc

Expected Behavior

Only lines containing session-abc should appear (2 lines).

Actual Behavior

All 3 lines are shown — session-xyz line included. Even filtering by a completely nonexistent session shows all lines:

$ cortex logs --session nonexistent-999
Log file: /home/user/.cache/cortex/logs/cortex-2024.log
------------------------------------------------------------
[2024-01-01 10:00:00] session-abc INFO: Message from session-abc
[2024-01-01 10:01:00] session-xyz INFO: Message from session-xyz
[2024-01-01 10:02:00] session-abc DEBUG: Another from session-abc

Screenshot (real binary output)

Root Cause

In src/cortex-cli/src/logs_cmd.rs, the session field is defined in the CLI struct but self.session is never read anywhere in the implementation. The run_show() and run_follow() functions only apply the level filter (self.level), and there is no equivalent code for session filtering.

The level filter works (lines 173-181):

let filtered_lines: Vec<&str> = if let Some(ref level) = self.level {
    let level_upper = level.to_uppercase();
    lines.iter().filter(|line| line.to_uppercase().contains(&level_upper)).copied().collect()
} else {
    lines
};

But there is no corresponding block for self.session.

File: src/cortex-cli/src/logs_cmd.rs, run_show() function (~line 167)

[atlas-cortex]

🔁 Validation Summary — Issue #53395

Issue is a duplicate of #53375 (similarity: 0.68)

Duplicate of #53375 — the original issue takes precedence.

Confidence Score: 5/5

• High confidence — this issue substantially overlaps with [BUG] [v0.0.7] cortex logs --session flag is silently ignored — session filter has no effect #53375.

Validation Checks

Check	Status	Detail
Media Evidence	✅ Pass	Evidence found and accessible
Spam Detection	✅ Pass	Score: 21% — no spam signals
Duplicate Detection	❌ Duplicate	Matches existing issue #53375
Code Verification	✅ Pass	Bug confirmed in source code (confidence: 100%) — The code confirms the bug report. The --session flag is defined in the CLI arg
Edit History	✅ Pass	No suspicious edits
LLM Evaluation	❌ Fail	Issue is a duplicate of #53375 (similarity: 0.68)

Validation Pipeline

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Issue #53395"] --> B{"Media Check"}
    B -->|"✅ Found"| C{"Spam Check"}
    C -->|"✅ Clean"| D{"Duplicate Check"}
    D -->|"Matches #53375"| Z["🔁 Duplicate"]
    style Z fill:#ffa94d,color:#fff

Loading

Raw Evidence

{
  "media": {
    "hasMedia": true,
    "accessible": true,
    "urls": [
      "https://raw.githubusercontent.com/nightmare0329/cortex-bug-evidence/main/real_logs_session_filter_bug.png"
    ],
    "evidence": [
      "Found 1 media URL(s) via GitHub rendered HTML",
      "1 URL(s) accessible"
    ]
  },
  "spam": {
    "overallScore": 0.20726495726495725,
    "details": "template=0.29 (5 recent issues compared); burst=1.00 (6 issues in 2h window); parity=0.00; overall=0.41 (threshold=0.7); llm_spam=0.00 (The issue presents a clear and specific title describing the failure of the `--session` flag. Reproducible steps are provided, detailing how to create a mock log file and the exact command to run. Expected and actual behaviors are explicitly defined, and a screenshot link is included in the body as visual evidence. The report also includes a detailed root cause analysis with code snippets, demonstrating a high level of technical understanding and confirming it is not spam. No duplicate issues were flagged.)"
  },
  "duplicate": {
    "isDuplicate": true,
    "originalIssue": 53375,
    "similarity": 0.6826993561795279,
    "topSimilar": [
      {
        "issueNumber": 53375,
        "title": "[BUG] [v0.0.7] `cortex logs --session` flag is silently ignored — session filter has no effect",
        "similarity": 0.6826993561795279
      },
      {
        "issueNumber": 52640,
        "title": "[BUG][v0.0.7] `cortex logs --session` / `-s` is accepted but never filters log output",
        "similarity": 0.6539219310139883
      },
      {
        "issueNumber": 51232,
        "title": "[BUG] [v0.0.7] cortex logs --session / -s is accepted but ignored — always tails/shows newest log file",
        "similarity": 0.6038741835146209
      },
      {
        "issueNumber": 51799,
        "title": "[BUG] [v0.0.7] `cortex sessions --since` and `--until` date filters are parsed but silently ignored",
        "similarity": 0.5787526557061635
      },
      {
        "issueNumber": 51533,
        "title": "[BUG] [v0.0.7] `cortex feedback bug --include-logs` silently does not include any logs in the feedback report",
        "similarity": 0.5547249454165064
      }
    ]
  },
  "editHistory": {
    "fraudScore": 0,
    "editCount": 0,
    "details": "No edits detected"
  },
  "codeVerification": {
    "plausible": true,
    "confidence": 1,
    "reasoning": "The code confirms the bug report. The `--session` flag is defined in the CLI arguments but its value is never used to filter the log lines in the implementation of `run_show` or `run_follow`. Only the `--level` flag is applied as a filter.",
    "codeEvidence": "In `src/cortex-cli/src/logs_cmd.rs`, the `LogsCli` struct defines `pub session: Option<String>`. However, in both `run_show` and `run_follow` methods, only `self.level` is used to filter the log lines. The `self.session` field is completely ignored, meaning the `--session` flag has no effect on the output.",
    "screenshotValid": true,
    "screenshotReasoning": "The screenshot shows the actual CLI execution where the `--session` flag is used but all log lines are still displayed, confirming the user-facing bug."
  }
}

_{Validated by Atlas • 2026-04-16}