Fixed a bug causing unique groups to toggle

Author: Pckool

package.json

@@ -18,9 +18,9 @@
 		"docs:generate:ref": "bun write-documentation.ts",
 		"postdocs:generate:ref": "bun format --all",
 		"bootstrap": "lerna bootstrap --use-workspaces",
-		"build": "bunx --bun lerna run build",
+		"build": "lerna run build",
 		"postbuild": "bun docs:generate:ref",
-		"dev": "bunx --bun lerna run build && bunx --bun lerna watch -- lerna run build --scope=$LERNA_PACKAGE_NAME",
+		"dev": "lerna run build && lerna watch -- lerna run build --scope=$LERNA_PACKAGE_NAME",
 		"prereleaseOnly": "pinst --disable && echo '🚀  Publishing...'",
 		"release-canary": "lerna run build && lerna publish --preid canary --no-private --yes --force-publish --canary",
 		"release-stable": "lerna run build && lerna publish --preid canary --no-private --yes --force-publish",

packages/plexus-core/src/collection/collection.ts

@@ -698,6 +698,7 @@ export class CollectionInstance<
 				for (const key of keys) {
 					const currentGroups = this.getGroupsOf(key, {
 						excludeDefault: true,
+						exclude: [groupName],
 					})
 					this.instance().runtime.log(
 						'debug',

packages/plexus-core/tsconfig.json

@@ -4,8 +4,7 @@
 		"lib": ["dom"],
 		"types": ["bun-types"],
 		"rootDir": "./src",
-		"outDir": "./dist",
-		"emitDeclarationOnly": true
+		"outDir": "./dist"
 	},
 	"include": ["./src/**/*"]
 }

tests/action.test.ts

@@ -1,4 +1,4 @@
-import { beforeEach, afterEach, describe, test, expect } from 'bun:test'
+import { beforeEach, afterEach, describe, test, expect } from 'vitest'
 
 import {
 	batchAction,

tests/api.test.ts

@@ -1,4 +1,4 @@
-import { beforeEach, afterEach, describe, test, expect } from 'bun:test'
+import { beforeEach, afterEach, describe, test, expect } from 'vitest'
 import { api, PlexusApi } from '@plexusjs/api'
 // only imported here to make sure it works in testing environment (node), not needed by user
 import 'isomorphic-fetch'

tests/basic.test.ts

@@ -1,4 +1,4 @@
-import { beforeEach, describe, expect, test } from 'bun:test'
+import { beforeEach, describe, expect, test } from 'vitest'
 import {
 	DEFAULT_DECAY_RATE,
 	arrayState,

tests/collection.test.ts

@@ -1,4 +1,4 @@
-import { beforeEach, afterEach, describe, test, expect } from 'bun:test'
+import { beforeEach, afterEach, describe, test, expect } from 'vitest'
 import { collection, instance, PlexusCollectionInstance } from '@plexusjs/core'
 import {
 	appointments,
@@ -428,6 +428,29 @@ describe('testing collection groups', () => {
 		expect(uniqueGroups.getGroup('group1').value.length).toBe(0)
 		expect(uniqueGroups.getGroup('group2').value.length).toBe(0)
 	})
+
+	test('Unique Groups should not toggle', () => {
+		uniqueGroups.collect(
+			[
+				{ firstName: 'Jack', userId: '0' },
+				{ firstName: 'Doe', userId: '1' },
+				{ firstName: 'Kane', userId: '2' },
+			],
+			'dynamic'
+		)
+		// should only add to one group
+		uniqueGroups.addToGroups('0', 'group2')
+		console.log(uniqueGroups.getGroupsOf('0'))
+		// two is default and group2 (last group in the array) and
+		expect(uniqueGroups.getGroupsOf('0').length).toBe(2)
+		expect(uniqueGroups.getGroup('dynamic').value.length).toBe(2)
+		expect(uniqueGroups.getGroup('group2').value.length).toBe(1)
+		// recollect the data
+		uniqueGroups.collect([{ firstName: 'Jack', userId: '0' }], 'group2')
+		expect(uniqueGroups.getGroupsOf('0').length).toBe(2)
+		expect(uniqueGroups.getGroup('dynamic').value.length).toBe(2)
+		expect(uniqueGroups.getGroup('group2').value.length).toBe(1)
+	})
 })
 describe('testing collection selectors', () => {
 	test('Do Selectors Work?', () => {

tests/computed.test.ts

@@ -1,4 +1,4 @@
-import { beforeEach, afterEach, describe, test, expect } from 'bun:test'
+import { beforeEach, afterEach, describe, test, expect } from 'vitest'
 
 import {
 	collection,

tests/controller.test.ts

@@ -1,4 +1,4 @@
-import { beforeEach, afterEach, describe, test, expect } from 'bun:test'
+import { beforeEach, afterEach, describe, test, expect } from 'vitest'
 
 import {
 	batchAction,

tests/edgecases.test.tsx

@@ -1,4 +1,4 @@
-import { beforeEach, afterEach, describe, test, expect } from 'bun:test'
+import { beforeEach, afterEach, describe, test, expect } from 'vitest'
 
 import {
 	batchAction,
@@ -89,7 +89,7 @@ describe('Collection Relations', () => {
 	)
 
 	test('Batching race condition with selectors', () => {
-		batch(() => {})
+		batch(() => { })
 	})
 })