test: Fix existing tests

Author: anth-volk

app/src/tests/unit/api/geographicAssociation.test.ts

@@ -255,14 +255,17 @@ describe('LocalStorageGeographicStore', () => {
       expect(result.createdAt).toBeDefined();
     });
 
-    it('given duplicate population then throws error', async () => {
+    it('given duplicate population then allows creation', async () => {
       // Given
       await store.create(mockPopulation1);
 
-      // When/Then
-      await expect(store.create(mockPopulation1)).rejects.toThrow(
-        'Geographic population already exists'
-      );
+      // When
+      const result = await store.create(mockPopulation1);
+
+      // Then - Implementation allows duplicates for multiple entries of same geography
+      expect(result).toEqual(mockPopulation1);
+      const allPopulations = await store.findByUser('user-123');
+      expect(allPopulations).toHaveLength(2);
     });
   });
 

app/src/tests/unit/components/common/PathwayView.test.tsx

@@ -362,11 +362,11 @@ describe('PathwayView', () => {
       expect(cancelButton).toBeDisabled();
     });
 
-    test('given cancel action then renders disabled cancel button', () => {
+    test('given cancel action with onClick then renders enabled cancel button', () => {
       render(<PathwayView title={PATHWAY_VIEW_STRINGS.MAIN_TITLE} cancelAction={mockCancelAction} />);
 
       const cancelButton = screen.getByRole('button', { name: PATHWAY_VIEW_STRINGS.CANCEL_BUTTON });
-      expect(cancelButton).toBeDisabled();
+      expect(cancelButton).not.toBeDisabled();
     });
 
     test('given user clicks primary button then calls primary handler', async () => {
@@ -382,7 +382,7 @@ describe('PathwayView', () => {
   });
 
   describe('Button Precedence', () => {
-    test('given explicit buttons and convenience props then explicit buttons take precedence', () => {
+    test('given explicit buttons and convenience props then uses new layout with actions', () => {
       render(
         <PathwayView
           title={PATHWAY_VIEW_STRINGS.MAIN_TITLE}
@@ -392,27 +392,21 @@ describe('PathwayView', () => {
         />
       );
 
-      // Should show explicit buttons, not the primary/cancel actions
+      // When convenience props are provided, they take precedence over explicit buttons
       expect(
-        screen.getByRole('button', { name: PATHWAY_VIEW_STRINGS.BACK_BUTTON })
+        screen.getByRole('button', { name: PATHWAY_VIEW_STRINGS.SUBMIT_BUTTON })
       ).toBeInTheDocument();
       expect(
-        screen.getByRole('button', { name: PATHWAY_VIEW_STRINGS.CONTINUE_BUTTON })
+        screen.getByRole('button', { name: PATHWAY_VIEW_STRINGS.CANCEL_BUTTON })
       ).toBeInTheDocument();
-      expect(
-        screen.queryByRole('button', { name: PATHWAY_VIEW_STRINGS.SUBMIT_BUTTON })
-      ).not.toBeInTheDocument();
-      expect(
-        screen.queryByRole('button', { name: PATHWAY_VIEW_STRINGS.CANCEL_BUTTON })
-      ).not.toBeInTheDocument();
     });
 
-    test('given no actions and no preset then renders default cancel button', () => {
+    test('given no actions and no preset then renders no buttons', () => {
       render(<PathwayView title={PATHWAY_VIEW_STRINGS.MAIN_TITLE} />);
 
-      expect(
-        screen.getByRole('button', { name: PATHWAY_VIEW_STRINGS.CANCEL_BUTTON })
-      ).toBeInTheDocument();
+      // Without any button configuration, no buttons are rendered
+      const buttons = screen.queryAllByRole('button');
+      expect(buttons).toHaveLength(0);
     });
   });
 });

app/src/tests/unit/utils/reportPopulationLock.test.ts

@@ -108,20 +108,20 @@ describe('reportPopulationLock', () => {
   });
 
   describe('getPopulationSelectionTitle', () => {
-    it('given shouldLock true then returns Apply Household(s)', () => {
+    it('given shouldLock true then returns Apply household(s)', () => {
       // When
       const result = getPopulationSelectionTitle(true);
 
       // Then
-      expect(result).toBe('Apply Household(s)');
+      expect(result).toBe('Apply household(s)');
     });
 
-    it('given shouldLock false then returns Select Household(s)', () => {
+    it('given shouldLock false then returns Select household(s)', () => {
       // When
       const result = getPopulationSelectionTitle(false);
 
       // Then
-      expect(result).toBe('Select Household(s)');
+      expect(result).toBe('Select household(s)');
     });
   });